Repository navigation
test: triage never-run tests and run the survivors nightly - #437
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About 90 tests in the repo never ran in CI: 74 socket test files in tests_v2 and 17 UI test classes. This sorts them out. Tests that pass now run every night in a new workflow, obsolete ones are deleted, and failing ones stay in the tree with their reasons listed below so someone can look at them.
PR checks are unchanged. The runner script only behaves differently when the nightly workflow sets its new environment variables.
What changed
.github/workflows/nightly-extended-tests.yml: runs every night and can be started by hand, with inputs to pick files, classes and the number of attempts. It builds the app once, runs tests_v2 in 3 shards, then the UI classes. A test that passes only on a retry is reported as FLAKY.scripts/run-tests-v2-ci.shgets optional settings for the test list, attempts, keep going after a failure, a per-test timeout and a results file.tests_v2/nightly_subset.txt(45 files) andscripts/nightly-ui-classes.txt(10 classes, 23 methods skipped).Deleted (11 tests_v2 files)
searchAllSurfacesis on, which is off by default and which the tests never turn on.Still failing, left in place and out of the nightly
These might be real bugs, so they were not deleted.
surface.split.list-panesreports pane_top -3.ls-style paths aren't resolved to the full path.Test runs
That check ran a version of the workflow that started on push to this branch. The final file drops that trigger and has one more UI skip. GitHub only schedules a workflow once it is on main, so the first real nightly run happens after merge; start it by hand once to confirm.