Repository navigation
fix: tmux pane geometry, palette debug snapshot, and stale socket tests - #440
Merged
Merged
Conversation
…e socket/palette tests tmux-compat list-panes printed a negative pane_top because pane frames are window-relative while the container starts below the titlebar; pane pixel frames are now offset by the container origin (added to pane.list) and divided by the point-sized cell, not the pixel-sized one. Tests follow deliberate contract changes: socket commands no longer steal focus (workspace.create does not select), bare indexes are rejected, focused-panel notifications are still recorded, untracked review files are "New file" rows, Codex hook ownership is an exact match, palette per-app open commands carry an app suffix. The fake agent in the screen-manifest test now clears its approval prompt so the idle prompt can win. The command palette UI class launches with a tag, the socket override and socket diagnostics, and the saved-description label is found by identifier.
…ree stale palette/review tests The debug command palette snapshot capped rows at 20 while the debug RPC accepts up to 100, so tests asking for 80 rows never saw later commands. The palette toggle opens in command mode with the > prefix, and the review test now runs in zsh so pasted comments stay inert (the CI login shell, bash 3.2, has no bracketed paste). Passing tests join the nightly list; the command palette UI class prints client socket errors.
… let the debug shortcut setter rename window/tab actions The sandboxed UI test runner gets EPERM connecting to sockets under /tmp. The debug shortcut setter only knew focus and digit shortcuts, so the hint-sync test could not rebind new_window, close_window and rename_tab.
…tte state on failure; add passing tests to the nightly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the test triage in #437. These socket and palette tests were failing in the nightly. Most of the failures were outdated tests, and three were real bugs, fixed here.
App fixes
pane_topcame out 3 rows too high because pane frames are in window coordinates while the container starts below the titlebar. The window size was also roughly halved on Retina, because it was divided by the pixel cell size instead of the point size.pane.listnow includes the container'sx/y, and the tmux shim subtracts that origin and divides by the point cell size.debug.shortcut.set(debug builds only) now acceptsnew_window,close_windowandrename_tab. Without them the shortcut hint sync test could never pass.Test updates
Each of these follows a change that was intentional, and each has its commit cited in a comment:
test_notifications.py:workspace.createno longer steals focus over the socket.test_review_diff_panel.py:diffable >= 1andfile_count >= 2.opencan rank either Open Folder or one of the per-app open commands first, and the test accepts either.>already typed.CommandPaletteAllSurfacesUITests:/tmp.Seven tests_v2 files join the nightly list, and the backspace UI test comes off the skip list.
Still open
test_notifications.pystill fail, because the pinned ghostty fork never dispatches OSC 99. That needs a fork commit.All of the above passed in manual nightly runs on this branch: 39292783144 and 39294950284 for v2, 39297584258 and 39298963225 for UI.