Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental draft, needs a maintainer decision. Do not merge as-is. It brings the Coder SDK to the latest release (v2.37.3) instead of the minimum-fix v2.29.19 in #524. govulncheck: 75 reachable to 30, the best of any single PR.
Changes:
replace tailscale.comand the netlinkreplace, as in chore: bump github.com/coder/coder/v2 from 2.26.5 to 2.29.19 #524, using the commit coder v2.37.3 pins.agentsdk.New(url, agentsdk.WithFixedToken(token)), as in chore: bump github.com/coder/coder/v2 from 2.26.5 to 2.29.19 #524.cdr.dev/slogtocdr.dev/slog/v3. The agentsdk log sender now takes a v3 logger. The change is limited to imports inlog/coder.goand its test.options.UnsetEnvclears_DD_ROOT_GO_SESSION_ID, because dd-trace-go 2.8 sets it at init. See the dd-trace-go PR.godirective goes to 1.26.5.Known failing test, decision needed:
TestEnvOptionParsing/bool/empty. coder v2.37 requirescoder/serpentv0.15, which removed the old rule that an empty env var counts as unset. With this PR,ENVBUILDER_GIT_CLONE_THINPACK=""sets the option tofalseinstead of leaving the default (true). This is a user-visible change. Options:ENVBUILDER_*env vars beforeserpentparses them, to keep the old behaviour.The Coder SDK was on a July 2024 snapshot until March 2026 (#487), and v2.26.5 is 11 minor releases behind current. If envbuilder keeps tracking coder/coder, this is the version to land eventually.
Generated by Coder Agents on behalf of @stirby.