Conversation
…508, GO-2026-6615 coder/coder v2.37.3 pulls these in at vulnerable versions.
serpent v0.15.0 (via coder/coder v2.37.3) makes an empty environment variable override an option's default. Filter empty values before option parsing so templates that pass empty strings keep their defaults, for example ENVBUILDER_WORKSPACE_BASE_DIR stays /workspaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines the security dependency bumps from #525, #526, #527, #528, #529, #530, #531 and #532 on current
mainand supersedes them. Most of them conflict withmainafter #533 and with each other ongo.sum, so this resolves all targets in onego get+go mod tidyinstead of merging branches.govulncheck (source mode, reachable findings): 26 on
main, 7 on this branch. The 7 remaining are already onmainand need a kaniko fork migration (buildkit, moby/go-archive) or have no upstream fix (docker/docker, docker-credential-acr-env). They are out of scope here.Commits:
agentsdk.WithFixedToken,osfs.WithBoundOSin tests) and chore: bump github.com/DataDog/dd-trace-go/v2 from 2.0.0 to 2.8.1 #529 (unset_DD_ROOT_GO_SESSION_ID).ENVBUILDER_X=""override the option default. That brokeTestEnvOptionParsing/bool/empty(also failing on chore: bump github.com/coder/coder/v2 from 2.26.5 to 2.37.3 #526) and would changeENVBUILDER_WORKSPACE_BASE_DIR=""from/workspacesto empty.options.ParseEnvirondrops empty values before parsing, which restores the previous behavior. The only difference from serpent v0.10: when bothENVBUILDER_X=""andHOMEBREW_ENVBUILDER_X=valueare set, the Homebrew value now applies.Validation:
make test: all packages pass, including 83 integration tests and a new regression test for an emptyWORKSPACE_BASE_DIR.make -j lint,./scripts/check_fmt.sh, andmake docs/env-variables.mdwith a clean diff.coder/codermain's devcontainer. The agent connected and code-server was healthy. A workspace on released1.3.0built the same repo for comparison.Not covered yet: the layer cache push and probe path, private repos over SSH, and customer devcontainers.
Companion provider PR: coder/terraform-provider-envbuilder#137, pinned to this branch's commit.
Decision log
go.mod/go.sum. Resolving them in one pass is equivalent to merging all of them and avoids hand-merginggo.sum.WORKSPACE_BASE_DIR,GIT_CLONE_THINPACK). Templates often build env lists with conditionals that yield"", so filtering in envbuilder keeps every existing template unchanged.docker/dockerv29 ormoby/moby, whichcoder/kanikodoes not support yet. grpc v1.83.2 (GO-2026-6443) is not included.gopkg.in/DataDog/dd-trace-go.v1v1.74.0 is marked retracted by its author; it comes from coder/coder, which uses the same version, and govulncheck reports no advisory for it.