Repository navigation
fix: use consistent error log level for overloaded hosts in capacity filter - #1421
Merged
Merged
Conversation
…filter The overloaded-host check used traceLog.Info for negative CPU but traceLog.Error for negative memory. Both conditions represent the same abnormal situation (host allocation exceeds effective capacity), so align the CPU path to use traceLog.Error to match the memory path. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
cortex-ai-agents
Bot
requested review from
PhilippMatthes,
SoWieMarkus,
auhlig,
juliusclausnitzer,
mblos and
umswmayj
as code owners
October 26, 2026 06:25
Collaborator
|
@claude I pushed some changes to this. Could you please take a look at this log line again and maybe convert it to a V1 log line if you think thats appropriate? |
Contributor
Author
|
Claude finished @SoWieMarkus's task in 2m 57s —— View job Review of the overloaded-host log lines
I looked at the full diff, the logging conventions across all filters, and the semantics of the two "invalid capacity" log lines at lines 291 and 319. My recommendation: keep
|
Collaborator
|
@claude then pls resolve the merge conflict |
Contributor
Author
|
Claude finished @SoWieMarkus's task in 2m 59s —— View job Resolved Merge Conflict
Resolved the merge conflict in I also updated the memory overloaded-host path (line 318) from Summary of changes:
|
Resolve merge conflict with main and align both CPU and memory overloaded-host log lines to use traceLog.V(1).Info(), consistent with the logging level reductions from the refactoring PRs. Co-authored-by: Markus Wieland <SoWieMarkus@users.noreply.github.com>
Contributor
Test Coverage ReportTest Coverage 📊: 71.4% |
SoWieMarkus
enabled auto-merge (squash)
October 26, 2026 10:27
SoWieMarkus
approved these changes
Oct 26, 2026
Merged
PhilippMatthes
added a commit
that referenced
this pull request
Oct 26, 2026
## Release cortex 0.7.2 ## Release PR [#1427](#1427) — 2026-10-26 ### Bumped Versions | Package | Previous | New | |---|---|---| | cortex | 0.7.1 | 0.7.2 | | cortex-postgres | 0.6.28 | 0.6.29 | | cortex-shim | 0.1.33 | 0.1.34 | | bundles | 0.0.108 | 0.0.109 | | cortex-placement-shim | 0.1.33 | 0.1.34 | ###⚠️ Deprecation - **`FailoverReservation` CRD deprecated:** The existing `FailoverReservation` type is now deprecated in favor of the new `FailoverHostReservation` subtype. Migrate any tooling referencing `FailoverReservation` to `FailoverHostReservation`. ### Features - **Failover Host Reservation CRD subtype** ([#1408](#1408)) — A new `FailoverHostReservation` reservation type supports reserving entire hosts for failover, enabling gang-scheduling of all VMs onto a designated host during evacuation events. Includes a full lifecycle model (Designated → Active → In Use → Used/Revoked/Failed), new spec (`FailoverHostReservationSpec`) with `sourceHosts` field, new status (`FailoverHostReservationStatus`) with `sourceHost` field, three new condition types (`FailoverHostDesignated`, `FailoverHostActive`, `FailoverHostInUse`), and CRD enum validation and kubebuilder print columns updated. - **New KVM Overview Perses dashboard** — Added `cortex-compute-kvm-overview.json` with rich visualizations for KVM compute infrastructure. ### Bug Fixes - **Filter out overloaded hosts** ([#1416](#1416)) — The capacity filter now correctly excludes hosts with negative free CPU or memory (allocation > effective capacity), which were previously silently passed through. - **Owner ref for CR reservations** ([#1403](#1403)) — Fixed setting owner references on committed-resource reservations. - **Confirm CR reservation allocations immediately** ([#1424](#1424)) — When a VM is already on the target hypervisor, reservation allocations are now confirmed immediately rather than waiting for a subsequent reconciliation cycle. - **Consistent error log level for overloaded hosts** ([#1421](#1421)) — Aligned CPU overload log to `traceLog.Error` to match memory overload log (was inconsistently using `traceLog.Info`). - **VM CRD added to Tilt** ([#1426](#1426)) — Added the `cobaltcore.cloud_virtualmachines` CRD to the Tiltfile for local development. ### Chores & Refactoring - **Logging unification — slog → controller-runtime/logr** ([#1400](#1400), [#1401](#1401), [#1404](#1404), [#1407](#1407)) — Completely removed `log/slog` from the codebase, unifying all logging under controller-runtime's logr (zap-backed). Translation rules: `slog.Info/Warn` → `log.Info`, `slog.Debug` → `log.V(1).Info`, `slog.Error(msg, "error", err)` → `log.Error(err, msg)`. Key interface changes: `Run` now takes `logr.Logger` instead of `*slog.Logger`; `GetTraceLogArgs()` returns `[]any` instead of `[]slog.Attr`; `APIMonitor.Respond` takes `logr.Logger`. The dead `LOG_LEVEL` env var was removed from the Helm template and a **forbidigo lint rule** banning `slog.*` prevents re-introduction. - **Logging level reduction** ([#1409](#1409), [#1410](#1410), [#1412](#1412), [#1413](#1413)) — Reduced verbosity across commitments, failover reservations, knowledge, and scheduling modules by downgrading non-essential log lines. - **Dashboard reorganization** ([#1399](#1399)) — Perses dashboards moved to a top-level `dashboards/` directory. The KVM details dashboard was renamed and updated with new color overrides, instant queries, an OS version pie chart, and a "Ready" column in the host table. ### Documentation - **Fix stale dashboard paths** ([#1422](#1422)) — Updated three docs files to reference `dashboards/` instead of the old `tools/perses/dashboards/` path; listed all 10 current dashboard filenames. ### Dependency Updates | Dependency | Old | New | PR | |---|---|---|---| | `debian:trixie-slim` | `a29215f` | `62bd423` (digest) | [#1398](#1398) | | `vm-operator` | v0.2.9 | v0.2.10 | [#1397](#1397) | | `kube-prometheus-stack` | 92.10.1 | 92.13.1 | [#1397](#1397), [#1420](#1420) | | `openstack-hypervisor-operator` | v1.2.3 | v1.3.0 | [#1414](#1414) | | `actions/setup-python` | v7.0.0 | v7.1.0 | [#1414](#1414) | | `sapcc/go-bits` | `416f3ad` | `568ad9d` (2 digest bumps) | [#1418](#1418), [#1419](#1419) | ###⚠️ Notes - **`openstack-hypervisor-operator` v1.3.0** brings parallel VM migrations during drains, safe eviction completion (incoming migrations must settle), hardened offboarding with `AgentPodsEvicted` gating, and node termination detection via `deletionTimestamp`. Review drain behavior in staging before rollout. - **slog removal:** Any out-of-tree code importing cortex packages that used `*slog.Logger` in `Run` or `GetTraceLogArgs` signatures must update to `logr.Logger` / `[]any`. **Contributors:** @PhilippMatthes, @SoWieMarkus, @mblos, @renovate[bot], @cortex-ai-agents[bot], Claude Opus 4.7 **PR:** [#1427](#1427) | **Commits:** 22 | **Files changed:** 95 ## Dependencies - Prep PR: #1428 (must be merged before this PR)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filter_has_enough_capacity.go, the overloaded-host check usedtraceLog.Infofor negative CPU (line 291) buttraceLog.Error(nil, ...)for negative memory (line 318). This asymmetry was introduced when fix: filter out overloaded hosts with negative free CPU/memory #1416 (filter out overloaded hosts) combined with the logging unification in refactor: unify logging to controller-runtime in scheduling pipeline #1404.traceLog.Error(nil, ...)to match the memory path.Test plan
🤖 Generated with Claude Code