Repository navigation
Tell translators what the auth code wait strings hold - #53
Merged
Merged
Conversation
A translator on Transifex asked what goes in the placeholder of these sentences. Say it's the wait, with examples, and since iOS writes the wait in its own words, which can't take another grammatical form, ask for sentences that read right with it as it is. The Android client gives its copies of these strings the same notes. problemMessage returns a LocalizedStringResource, as LocalizedStringKey can't carry a comment. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q9Kb2PrrBMXJ5Y89E3CKib
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q9Kb2PrrBMXJ5Y89E3CKib
ScreenshotsFrom run 39798992775, against a real Clementine. Left: main. Right: this pull request, light and dark.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by John · project thread
The iOS half of clementine-player/Android-Remote#354, which gives the Android copies of these strings the same notes.
A translator on Transifex asked what goes in the placeholder of the "too many wrong auth codes" sentences. This adds a translator comment on both sentences and on "a while". The comment says the placeholder is the wait ("10 seconds", "1 minute", "3 minutes", "2 hours", or "a while"). Here the wait comes from
Duration.formattedin iOS's own words, so it can't take another grammatical form, and the comment asks for sentences that read right with it as it is.problemMessagenow returns aLocalizedStringResource, becauseLocalizedStringKeycan't carry a comment. The other keys don't change:Stringinterpolations are%@either way.Localizable.xcstringsby hand, because I had no Xcode. CI's string sync will show whether Xcode writes them the same way.CLAUDE.mdnow says that translations are shared with the Android client, and that a shared string gets the same English and the same note in both.Only comments for translators change, so there's no release note. I couldn't build this here (no Swift toolchain on Linux), so CI is the first build.
Generated by Claude Code