Repository navigation
Tell translators what the auth code wait strings hold - #354
Merged
Merged
Conversation
A translator on Transifex asked what goes in the %s of too_many_wrong_auth_codes. Say it's the wait from the wait_ strings, with examples, on both strings that use it, and on the wait_ strings say which sentence they go into. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q9Kb2PrrBMXJ5Y89E3CKib
The iOS remote shares these sentences' translations, and writes the wait in iOS's own words, which can't be put in another grammatical form. So ask for the sentences to read right with the wait as it is, in the same note the iOS strings get, and for the wait_ strings to be plain durations. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q9Kb2PrrBMXJ5Y89E3CKib
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q9Kb2PrrBMXJ5Y89E3CKib
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q9Kb2PrrBMXJ5Y89E3CKib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by John · project thread
The Android half of clementine-player/iOS-Remote#53, which gives the iOS copies of these strings the same notes.
A translator on Transifex asked what goes in the
%softoo_many_wrong_auth_codes. It's the wait fromRetryWait.describe: one of thewait_seconds,wait_minutesorwait_hoursplurals ("10 seconds", "3 minutes", "2 hours"), orwait_a_while("a while").too_many_wrong_auth_codesanddownload_noti_too_many_wrong_auth_codesget the same comment as their iOS copies: what the placeholder holds, with examples. The iOS app writes the wait in iOS's own words, which can't take another grammatical form, and the two clients share translations, so the comment asks for sentences that read right with the wait as it is. Transifex shows these comments to translators as the string's developer note.wait_strings asks for plain durations, to match.wait_a_whilegets its own comment.CLAUDE.mdnow says that translations are shared with the iOS client, and that a shared string gets the same English and the same note in both.Only comments and docs change, so there's no release note. I couldn't build here (no Android Gradle plugin offline). The file parses as XML, and CI will build it.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Q9Kb2PrrBMXJ5Y89E3CKib