Repository navigation
Rate songs in half stars - #52
Merged
Merged
Conversation
Each rating star rated the song a whole number of stars, so the half stars Clementine has couldn't be given. A tap on a star's leading half now rates it half a star less, as on Android. VoiceOver still reads one button per star, which rates the whole star, and offers the half star as an action on it. The two new strings are added to the catalog as a build's sync would add them. Release-note: You can rate songs in half stars: tap the left half of a star. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XFkkp5H5UZTWDyEMm6jnZH
ScreenshotsFrom run 39798189865, against a real Clementine. Left: main. Right: this pull request, light and dark.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by John · project thread
The iOS side of clementine-player/Android-Remote#353. Each rating star rated the song a whole number of stars, so the half stars Clementine stores couldn't be given.
RemoteSession.rate(stars:)takes aFloat, rounded to half stars and clamped to 0–5.Rate %@ starsandRated %@ stars.Testing
Not yet tried on a device. The half-star tap relies on SwiftUI's local coordinates starting from the leading edge, so it's worth checking in a right-to-left language.
🤖 Generated with Claude Code
https://claude.ai/code/session_01XFkkp5H5UZTWDyEMm6jnZH