Repository navigation
Rate songs in half stars again - #353
Merged
Merged
Conversation
The song details' stars became five icon buttons, each rating the song a whole number of stars, so the half stars Clementine has could no longer be given. A tap on a star's left half now rates it half a star less, as the old rating bar did. TalkBack still reads one button per star, which rates the whole star, and offers the half star as an action on it. Release-note: You can rate songs in half stars: tap the left half of a star. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XFkkp5H5UZTWDyEMm6jnZH
hatstand
force-pushed
the
claude/android-remote-issue-352-jq19tx
branch
from
October 22, 2026 14:42
39a52e7 to
7c26f04
Compare
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XFkkp5H5UZTWDyEMm6jnZH
Store screenshotsFrom run 39800852689, against clementine-it. Left: the store listing of the latest release, v13.9, which shows the dark theme. Right: this pull request, dark and light.
|
Robolectric's screen is 320dp wide, which cuts off the fifth star, so a tap on its right half missed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XFkkp5H5UZTWDyEMm6jnZH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by John · project thread
The redesigned song details made each rating star an
IconButtonthat rates the song a whole number of stars. Half stars, which Clementine stores and its remote protocol accepts as a float, could no longer be given. This is the regression reported in issue 352.song_info_rate_half_stars.The iOS client gets the same change in clementine-player/iOS-Remote#52.
Testing
PlayerScreenTest.songDetailsShowWhatClementineKnowstaps the left and right halves of stars and uses the TalkBack action.🤖 Generated with Claude Code
https://claude.ai/code/session_01XFkkp5H5UZTWDyEMm6jnZH