Repository navigation
[python] Delegate predicate deletion to native TableUpdate - #10507
Merged
JingsongLi merged 1 commit intoOct 12, 2026
Merged
Conversation
leaves12138
approved these changes
Oct 11, 2026
leaves12138
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the Python facade and Java-semantics alignment. Native predicate deletes keep preparation failures on the fallback path while operation failures propagate, support batch/stream and partition/row predicates, and preserve snapshot/conflict semantics. The focused Python tests and all completed CI checks pass; Native CI is still pending. No blocking issues found.
JingsongLi
marked this pull request as ready for review
October 12, 2026 00:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Use native execution for PyPaimon's existing
BatchTableUpdateandStreamTableUpdate.delete_by_predicate. Previously Python still planned partition metadata deletion or collected all matched row IDs before invoking the native row-ID writer.Depends on apache/paimon-rust#1105. Keep this draft until that PR reaches Rust
main; Native CI continues to build upstreammain.Changes
Java semantics
FileStoreCommitImpl.configureRowIdCheckFromMessagesconfigures row-ID checking; it does not enableStrictModeChecker. The stricter checker is constructed only when an explicit last-safe snapshot is configured.DataEvolutionConflictDetectionignores fresh row IDs beyond the baseline and checks overlapping historical row/column writes. Python now follows this default behavior.Verification
Built the paired Rust extension locally and enabled Native planning, reads, writes and commits:
Prepared files remain preserved on commit failures or unknown outcomes.