Repository navigation
[Core] Add predicate deletes to TableUpdate - #1105
Merged
Merged
Conversation
leaves12138
approved these changes
Oct 11, 2026
leaves12138
left a comment
There was a problem hiding this comment.
Reviewed the Rust core and Python binding changes. Predicate deletes capture one snapshot, correctly separate partition metadata deletion from row-level deletion-vector preparation, include pending/index files, and preserve conflict baselines. The focused tests and all Rust CI checks pass. No blocking issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
PyPaimon already supports
delete_by_predicate, but native updates expose only row-ID deletion. Python still reads partition manifests or materializes matched row IDs before invoking Rust. Move that complete existing operation into Rust core.Changes
TableUpdate::delete_by_predicate, with batch and stream Python wrappers and updated type stubs.Java semantics
Reuse Java-compatible commit-message baselines, anchor selection and DV replacement checks. Default file/DV/row-ID conflict detection preserves later appends with fresh row IDs and rejects conflicting replacements. Java's stricter partition-level checker is configured separately through an explicit last-safe snapshot; a message baseline alone does not enable it. The paired Python change removes its extra coarse partition check.
Verification
cargo +1.98.0 clippy -p paimon -p pypaimon_rust --all-targets -- -D warningsandcargo fmt --all --checkpassed.Paired PyPaimon adapter and Java-semantics alignment: apache/paimon#10507.