Repository navigation
[5.4.x] Notify the callbacks of lease requests failed by StrictConnPool eviction - #736
Closed
arturobernalg wants to merge 1 commit into
Closed
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
…vailable and #enumLeased enumAvailable() and enumLeased() expire pending lease requests through processPendingRequests() but did not fire the completion callbacks. The futures of requests that timed out stayed uncompleted until the next lease or release, so closeExpired() and closeIdle() did not enforce the lease request timeout on an otherwise idle pool. (cherry picked from commit 9983b03)
ok2c
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #735 (9983b03) to 5.4.x, as requested.
StrictConnPool#enumAvailable() and #enumLeased() expire pending lease requests through processPendingRequests() but never fire the completion callbacks, so closeExpired() and closeIdle() do not fail a timed out lease request on an otherwise idle pool.
The production change applies unchanged. The test is adapted, as 5.4.x has no clock injection: it uses the real clock with a 50 ms request timeout. Without the fix the two STRICT cases fail.