Repository navigation
Notify the callbacks of lease requests failed by StrictConnPool eviction - #735
Merged
arturobernalg merged 1 commit intoNov 2, 2026
Merged
Conversation
…vailable and #enumLeased enumAvailable() and enumLeased() expire pending lease requests through processPendingRequests() but did not fire the completion callbacks. The futures of requests that timed out stayed uncompleted until the next lease or release, so closeExpired() and closeIdle() did not enforce the lease request timeout on an otherwise idle pool.
ok2c
approved these changes
Nov 2, 2026
Member
|
@arturobernalg Please cherry-pick to |
Member
Author
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StrictConnPool#enumAvailable() and #enumLeased() expire pending lease requests through processPendingRequests() but never fire the completion callbacks. The future of a request that timed out stays uncompleted until the next lease or release, so closeExpired() and closeIdle() do not enforce the lease request timeout on an otherwise idle pool.
Both methods now call fireCallbacks() after releasing the lock, as validatePendingRequests() does.
TestPoolPendingRequestExpiry checks closeExpired() and closeIdle() on all three pools. Only StrictConnPool failed before the change; LaxConnPool and RouteSegmentedConnPool already complete the future of an expired request.
Raised in HTTPCLIENT-2437.