Repository navigation
chore: update C++ and Java snapshots to latest upstream - #13
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Move the Java snapshot pin from 3a1bf7f to 059b5a9, the merge of apache/datasketches-java#774, and regenerate the Java snapshots. Deterministic changes: - HLL_6 and HLL_8 compact images set the compact flag (java#761). - Empty tuple and AoS compact images write a zero seed hash. - Adds frequent_long_purged and frequent_string_purged (java#770). All other modifications are probabilistic snapshots. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Move the C++ snapshot pin from fe0261a to 16d4ea6 and regenerate the C++ snapshots. Deterministic changes: - Single-item compact theta images set the single-item flag (cpp#526). - Adds frequent_long_purged and frequent_string_purged (cpp#529). - Removes the 27 aos_*_cpp.sk snapshots: the C++ array-of-strings tuple sketch was reverted (cpp#537) because its key hashing is incompatible with Java (cpp#533). All other modifications are probabilistic snapshots. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 4, 2026
tisonkun
approved these changes
Oct 4, 2026
tisonkun
added a commit
that referenced
this pull request
Oct 4, 2026
Main contains the squash merge of #13 and has the same tree as the parent of the layout change. Preserve the PR tree so all 731 snapshots keep their existing contents at the new paths. Validated with mise run check and exact blob comparisons for all moved snapshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the C++ and Java snapshot pins to the current upstream default branches and regenerates their snapshots. Also keeps
.skfiles tracked when a contributor's global gitignore excludes them.Commits
.sksnapshots even when a global gitignore excludes them. Adds!*.skto.gitignore.3a1bf7f→059b5a9(merge of Fix theta preamble count for legacy single-item images datasketches-java#774). Deterministic changes:frequent_long_purgedandfrequent_string_purged(java#770).fe0261a→16d4ea6(currentmaster). Deterministic changes:frequent_long_purgedandfrequent_string_purged(cpp#529).aos_*_cpp.sksnapshots. The C++ array-of-strings tuple sketch was reverted (Revert #476: remove the array-of-strings tuple sketch for 5.3.0 datasketches-cpp#537) because its key hashing is incompatible with Java (Array-of-strings tuple sketch: key hashing is incompatible with Java (UTF-8 vs UTF-16) datasketches-cpp#533).All other modified files are probabilistic snapshots.
Not included: Go
Go
maincan't currently generate its theta and tuple snapshots. A lint cleanup (go#181) made the generators fail onErrHashExceedsTheta, whichUpdatereturns by design. The fix is in a separate datasketches-go PR. The Go pin stays at757a485until that lands.Verification
mise run tck -- snapshots update cpp masterandsnapshots update java mainmise run tck -- snapshots update all: C++ and Java already match their latest commitsmise run checkThe PRs for #11 and #12 are stacked on this one.
🤖 Generated with Claude Code