Repository navigation
Use the serialization_test_data/<lang>_generated_files layout - #14
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Move the Java snapshot pin from 3a1bf7f to 059b5a9, the merge of apache/datasketches-java#774, and regenerate the Java snapshots. Deterministic changes: - HLL_6 and HLL_8 compact images set the compact flag (java#761). - Empty tuple and AoS compact images write a zero seed hash. - Adds frequent_long_purged and frequent_string_purged (java#770). All other modifications are probabilistic snapshots. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Move the C++ snapshot pin from fe0261a to 16d4ea6 and regenerate the C++ snapshots. Deterministic changes: - Single-item compact theta images set the single-item flag (cpp#526). - Adds frequent_long_purged and frequent_string_purged (cpp#529). - Removes the 27 aos_*_cpp.sk snapshots: the C++ array-of-strings tuple sketch was reverted (cpp#537) because its key hashing is incompatible with Java (cpp#533). All other modifications are probabilistic snapshots. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Move the snapshots from serialization/<lang>/snapshots to serialization_test_data/<lang>_generated_files, the layout that datasketches-java, datasketches-go and (with cpp#535) datasketches-cpp already use for cross-language fixtures. A TCK checkout can then serve directly as an implementation's test data root, and moving files between the TCK and an implementation is a plain copy. The file contents are unchanged; only their directory moves. Closes #11 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Main contains the squash merge of #13 and has the same tree as the parent of the layout change. Preserve the PR tree so all 731 snapshots keep their existing contents at the new paths. Validated with mise run check and exact blob comparisons for all moved snapshots.
tisonkun
approved these changes
Oct 4, 2026
tisonkun
added a commit
that referenced
this pull request
Oct 4, 2026
Reconcile the snapshot directory migration from #14 with the latest-snapshot update workflow. Preserve the snapshot corpus from main, retain the update behavior, and use serialization_test_data in the workflow and documentation. Validated with mise run check and exact snapshot comparisons against main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11.
Stacked on #13. Review that one first. This PR's base will switch to
mainonce #13 merges.Moves the snapshots from
serialization/<lang>/snapshots/toserialization_test_data/<lang>_generated_files/. That's the layout datasketches-java and datasketches-go already use for cross-language fixtures, and datasketches-cpp is moving to it (apache/datasketches-cpp#535). A TCK checkout can then serve directly as an implementation's test data root, and moving files between the TCK and an implementation is a plain copy.Changes
git mvof all 735.skfiles. File contents are unchanged.internal/snapshots/reconcile.go: asnapshotDirectoryhelper now holds the layout in one place.cmd/tckoutput test and snapshot: updated to the new path.docs/serialization-snapshots.md: new paths, and a note on why the layout matches the implementations.Verification
mise run checkmise run tck -- snapshots check goagainst the moved files: file set and deterministic contents match.Follow-up
Java's
tools/download_serialization_test_data.shneeds a small change after this merges: the member pattern becomes*/serialization_test_data/<lang>_generated_files/*.sk,--strip-componentsgoes from 4 to 3, andTCK_REVISIONmoves to the merge commit.🤖 Generated with Claude Code