Skip to content

fix: MoveToFirst returns false when already on the first sibling #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhengchun merged 1 commit into from
Oct 10, 2026
Merged

fix: MoveToFirst returns false when already on the first sibling #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,11 @@ func (a *NodeNavigator) MoveToChild() bool {
}

func (a *NodeNavigator) MoveToFirst() bool {
// Already on the first sibling. xmlquery and htmlquery return false
// here so a caller can tell the navigator did not move.
if a.cur.PrevSibling == nil {
return false
}
for n := a.cur.PrevSibling; n != nil; n = n.PrevSibling {
a.cur = n
}
Expand Down
17 changes: 17 additions & 0 deletions query_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,23 @@ func BenchmarkDisableSelectorCache(b *testing.B) {
}
}

func TestMoveToFirst(t *testing.T) {
doc, err := parseString(`{"a":1,"b":2}`)
require.NoError(t, err)

nav := CreateXPathNavigator(doc)
require.True(t, nav.MoveToChild())
require.Equal(t, "a", nav.Current().Data)
// Already on the first sibling. The move did not happen.
require.False(t, nav.MoveToFirst())
require.Equal(t, "a", nav.Current().Data)

require.True(t, nav.MoveToNext())
require.Equal(t, "b", nav.Current().Data)
require.True(t, nav.MoveToFirst())
require.Equal(t, "a", nav.Current().Data)
}

func TestNavigator(t *testing.T) {
s := `{
"name":"John",
Expand Down