Repository navigation
fix: MoveToFirst returns false when already on the first sibling - #28
Merged
Merged
Conversation
The method returned true without moving. xmlquery and htmlquery return false in that case, so a caller can tell the navigator did not move.
Contributor
Author
|
Thanks for merging this. MoveToFirst stays false when it is already on the first sibling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NodeNavigator.MoveToFirstreturned true when the navigator was already on the first sibling, and it did not move.xmlquery,htmlquery, and the xpath package's own test navigator return false in that case. A caller that keeps calling the method until it returns false never stops.Moving from a later sibling back to the first one still returns true.
Test plan
go test -count=1 ./...TestMoveToFirstfailed before the guard (Should be falseon the first sibling) and passes with it. The existing navigator tests still pass.