Skip to content

fix(install): revalidate npm metadata so updates get the new release - #439

Merged
Waishnav merged 1 commit into
mainfrom
fix/installer-prefer-online
Oct 30, 2026
Merged

Waishnav merged 1 commit into
mainfrom
fix/installer-prefer-online

Conversation

@Waishnav

@Waishnav Waishnav commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner

Right after 1.1.0-beta.6 was published, running the installer still installed 1.1.0-beta.5. The registry already reported the new beta tag, but npm install resolved it from package metadata cached locally before the publish. Since rerunning the installer is how users update, the same thing would make an update quietly reinstall the old version for a while after each release.

Both installers now pass --prefer-online, which makes npm revalidate cached metadata before resolving the dist-tag. Verified by installing through the installer with fresh metadata: it resolved beta to 1.1.0-beta.6, doctor reported node:sqlite, and the agent daemon started.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Improvements
    • Windows and Unix-like installers now prefer online npm metadata and revalidate cached information during installation. This helps ensure installation uses up-to-date package metadata while preserving the existing Node selection and installation options.

npm reuses cached package metadata, so running the installer shortly
after a release (or to update) could resolve the dist-tag to the
previous version. Right after 1.1.0-beta.6 was published, a fresh
install still got 1.1.0-beta.5. --prefer-online revalidates the cache.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 876e0f7b-1717-48af-b586-f453ec0ecbbf
Commits

Reviewing files that changed from the base of the PR and between a42937d and dc19260.

Files selected for processing: 2
  • install/install.ps1
  • install/install.sh

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review.

Walkthrough

Both the Windows and Unix installers add npm’s --prefer-online option to their package installation commands. Existing Node PATH setup and other install options remain unchanged.

Changes: Installer metadata revalidation

Layer / File(s) Summary
Update npm install commands
install/install.ps1, install/install.sh
Both installers add --prefer-online to their npm install command. The existing Node PATH setup and other install options remain unchanged.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Bug fix

Possibly related PRs

  • Waishnav/devspace#436: Changes both installers’ version defaults and documents reruns as the update path.
  • Waishnav/devspace#435: Runs both installers and reruns the Unix installer, then checks the installed version.
  • Waishnav/devspace#434: Introduces the shell and PowerShell installers and their npm installation commands.
Merge Risk: Minimal · up to dc192

The installers now request fresh package metadata while retaining cached-response fallback for network failures in the inspected npm version. No actionable merge-blocking issue was established.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: installers revalidate npm metadata so updates resolve the new release.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the npm trail,
Fresh metadata, no stale detail.
Two installers hop along,
With --prefer-online in their song.
The cached crumbs give way to spring.

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅

View logs ↗
No Preview URL. Enable ↗ dc19260 2026-10-30T08:27:34.020Z Visit the dashboard ↗

@Waishnav
Waishnav merged commit c7e2712 into main Oct 30, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant