Skip to content

fix: merge adjacent selected ranges and validate the full premerge workflow - #5345

Merged
Rui-Sun merged 12 commits into
developfrom
codex/workflow-e2e-20261019
Oct 19, 2026
Merged

Rui-Sun merged 12 commits into
developfrom
codex/workflow-e2e-20261019

Conversation

@Rui-Sun

@Rui-Sun Rui-Sun commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

变更

接续已关闭、未合入的 #5320,修复自动多选时相邻矩形选区的合并行为,保留表头投影和非矩形边界。归并后 Shift 续选保留最后活动锚点,局部归并复用无关选框,避免一万稀疏选区全量重建。

当前结论

当前 head 26501654ac7ab055e637b2fa2d960c4b1723ee85、官方 develop 9432ef78dc56f011c9175de64fc6cfdff2fd6825 的新工作流合入前门禁已完成。请以唯一 Bot 摘要、当前五项固定 Checks 和 Bot Review 为准。本轮停在人工审阅阶段,暂不合入,也未发布资产。

  • 自动可信完整 CI:12/12 构建、1027/1027 单测、Firefox paste 1/1;Linux 仓库视觉 204/204 匹配,零失败、差异或跳过。派发回执没有被当作测试通过。
  • 当前版本完整 CR:原两项问题均已验证修复,开放阻断 0;公开 Review 已原位注明最新 SHA。GitHub 对 App 返回无关闭讨论权限,两条已修复讨论需管理员点击 Resolve conversation。
  • 自动 BOE 双执行器:Photo 1/1、Playwright 204/204 匹配,零错误或跳过,完整报告及清理已确认。Photo 语义断言、绘制和稳定性为 not_supported;Playwright 对应检查通过。
  • 正式资产计划已由自动流程创建并关联原 run:204 项用例版本更新、0 项基准替换,计划摘要 17fee70f38912af4a0c4fc538abd5786a2ef7c89a1e78776392d264df9cf24fa;尚未执行发布。
  • 本地修复反例及回归:相关 30 项、完整推送单测 1027 项、对官方 develop 全量视觉 204 项通过。

管理员需要关注

本 head 的旧 Bug Server CI已完成但失败:旧 Photo 共 2231 项,2192 项成功,39 项未通过,失败集合尚未逐项分类。本次 Photo 试点和 Git 管理的视觉套件不能替代这批旧数据;五项新工作流 Checks 通过不代表仓库全部 CI 通过。请在最终审阅中核对这项独立结果,保留真实失败,不通过替换生产基准或放宽阈值消除告警。

分支保护仍要求 Code Owner 人工批准和关闭未解决讨论,本轮未更改保护规则。实际合入、合入后资产发布和外部 fork PR 另行验收。

@visactor-review-bot

visactor-review-bot Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

VisActor 工作流结论:PR 已合入,资产发布已完成

PR #5345 · generation 2 · 证据状态:current

  • head:26501654ac7ab055e637b2fa2d960c4b1723ee85
  • base:9432ef78dc56f011c9175de64fc6cfdff2fd6825
  • 更新时间:2026-10-19T10:10:56.698Z
阶段 结果 依据 / 下一步
Build 通过 检查详情
Unit 通过 检查详情
Repository visual 通过 检查详情
BugServer 通过 本 PR 检查
CR 完整审查 开放阻断:0;详见本 PR 的 Bot Review
Merge readiness 已合入,跟踪后续同步 PR 已合入,资产发布已完成

BugServer 执行范围

执行器 集合 匹配 差异 无基准 断言/执行错误 跳过/取消
Photo 完整 1 0 0 0 0
Playwright 完整 204 0 0 0 0

Photo 的语义断言、绘制和稳定性能力为 not_supported;其图片匹配不代表这些能力通过,也不代表旧 Photo 全数据集通过。Playwright 的执行检查须由完整原始结果验证。

资产计划

用例版本变更:204;基准变更:0。计划摘要:17fee70f38912af4a0c4fc538abd5786a2ef7c89a1e78776392d264df9cf24fa。本计划已发布,详见下方合入后记录。

合入后同步

状态:资产发布已完成

  • 实际合入提交:fa59fcacd530ab3de744616c4cf2da131584f8c0
  • 复验运行:ee7879a79fff61e85ddbb6b9572ba8850c1c6064b6d6c7f802513cc346e99ada
  • 发布任务:9fe86379544e4c3d4c4338536802f8fdc9bb014c12605e951d38901425ac828a
  • 原资产版本:7155bae485e971b99121540dadd9448531661538999bccb03564bd749808fdfc
  • 新资产版本:5a625871884dd3939dab6746bbbf35a2e56f008523bc7780fd24d04d63284b91
  • 错误代码:无

其他仓库 CI:当前未发现额外的未通过检查;仅说明本次查询结果。

管理员下一步

已按原审查计划完成资产同步,发布记录及历史报告保持可追溯。 本节只描述当前合入与发布任务;其他PR和全仓启用另行验收。

查看全部 Checks · 查看当前公开用例源码

{
  "schemaVersion": 1,
  "contractVersion": "1.0",
  "kind": "pr_status",
  "repository": "VisActor/VTable",
  "pullRequest": 5345,
  "generation": 2,
  "identity": {
    "repository": "VisActor/VTable",
    "productKey": "VTable",
    "pullRequest": 5345,
    "headSha": "26501654ac7ab055e637b2fa2d960c4b1723ee85",
    "baseSha": "9432ef78dc56f011c9175de64fc6cfdff2fd6825",
    "baseRef": "develop",
    "controlCommit": "e3d0c438049be9bfd27483e439e0ad1f15fa6ee5",
    "subject": {
      "kind": "pr_head",
      "testedCommit": "26501654ac7ab055e637b2fa2d960c4b1723ee85",
      "mergeParents": [],
      "sourceDigest": "90e49f6be76010635d8f68a142fbe5503833f7988d4e7e005ff8e5e718cc5585"
    },
    "bundleDigest": "31e4ff17e42e97e180091929749c367d8f8b0653652f13ba8862f8fcb68c7769",
    "suiteDigests": {
      "photo": "af95feea2489f665501a03d228b3956dfcb53b3b7c760b1580beb066e39d2b94",
      "playwright": "d7950ff3238b75bab0c0b2606040aa88142e653d8b9f3cc09688df7e9ec09327"
    },
    "environmentIds": {
      "photo": "sec01-linux-ae13ce92ad39b13fd8da1312-vtable-photo",
      "playwright": "sec01-linux-ae13ce92ad39b13fd8da1312-vtable"
    },
    "assetRevision": "7155bae485e971b99121540dadd9448531661538999bccb03564bd749808fdfc",
    "policyDigest": "553aabd58a4d0a852e6cca1699c008144f977f17990feb90938e234f5b69efcb"
  },
  "freshness": "current",
  "phase": "postmerge",
  "requiredChecks": [
    {
      "key": "build",
      "status": "passed",
      "evidenceUrls": [
        "https://github.com/VisActor/VTable/runs/117905469311"
      ]
    },
    {
      "key": "unit",
      "status": "passed",
      "evidenceUrls": [
        "https://github.com/VisActor/VTable/runs/117905499341"
      ]
    },
    {
      "key": "repository_visual",
      "status": "passed",
      "evidenceUrls": [
        "https://github.com/VisActor/VTable/runs/117905530140"
      ]
    },
    {
      "key": "bugserver",
      "status": "passed"
    }
  ],
  "review": {
    "status": "completed",
    "coverage": "full",
    "blockingOpen": 0
  },
  "testSummaries": [
    {
      "engine": "photo",
      "rawOutcome": "passed",
      "complete": true,
      "counts": {
        "matched": 1,
        "different": 0,
        "no_baseline": 0,
        "assertion_failed": 0,
        "execution_error": 0,
        "skipped": 0,
        "cancelled": 0
      }
    },
    {
      "engine": "playwright",
      "rawOutcome": "passed",
      "complete": true,
      "counts": {
        "matched": 204,
        "different": 0,
        "no_baseline": 0,
        "assertion_failed": 0,
        "execution_error": 0,
        "skipped": 0,
        "cancelled": 0
      }
    }
  ],
  "mergeEligibility": null,
  "recommendation": null,
  "planSummary": {
    "planDigest": "17fee70f38912af4a0c4fc538abd5786a2ef7c89a1e78776392d264df9cf24fa",
    "caseChanges": 204,
    "baselineChanges": 0
  },
  "postMerge": {
    "state": "published",
    "publishJobId": "9fe86379544e4c3d4c4338536802f8fdc9bb014c12605e951d38901425ac828a",
    "error": null,
    "mergedCommit": "fa59fcacd530ab3de744616c4cf2da131584f8c0",
    "verificationRunId": "ee7879a79fff61e85ddbb6b9572ba8850c1c6064b6d6c7f802513cc346e99ada",
    "previousRevision": "7155bae485e971b99121540dadd9448531661538999bccb03564bd749808fdfc",
    "newRevision": "5a625871884dd3939dab6746bbbf35a2e56f008523bc7780fd24d04d63284b91"
  },
  "nextActions": [
    {
      "actorRole": "platform_maintainer",
      "actionCode": "postmerge_complete",
      "reasonCode": "ASSET_PUBLICATION_VERIFIED",
      "text": "The reviewed assets were published from the verified merged commit.",
      "evidenceUrls": [
        "https://github.com/VisActor/VTable/pull/5345"
      ]
    }
  ],
  "acceptedAdvice": {
    "generation": 2,
    "headSha": "26501654ac7ab055e637b2fa2d960c4b1723ee85",
    "planDigest": "17fee70f38912af4a0c4fc538abd5786a2ef7c89a1e78776392d264df9cf24fa",
    "recommendation": "merge_with_asset_update",
    "acceptedAt": "2026-10-19T09:08:49Z"
  },
  "updatedAt": "2026-10-19T10:10:56.698Z"
}

@visactor-review-bot visactor-review-bot Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最新复查提交: 2650165

未发现可确认的新问题;此前两处问题已修复。

Comment thread packages/vtable/src/state/select/auto-merge-ranges.ts
Comment thread packages/vtable/src/state/state.ts Outdated
@Rui-Sun
Rui-Sun merged commit fa59fca into develop Oct 19, 2026
12 of 13 checks passed
@Rui-Sun
Rui-Sun deleted the codex/workflow-e2e-20261019 branch October 19, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants