Skip to content

test: 补齐全选表体用例的列边界断言 - #5346

Closed
Rui-Sun wants to merge 2 commits into
developfrom
codex/workflow-assertion-lifecycle-20261019
Closed

Rui-Sun wants to merge 2 commits into
developfrom
codex/workflow-assertion-lifecycle-20261019

Conversation

@Rui-Sun

@Rui-Sun Rui-Sun commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

🤔 这个分支是...

  • 新功能
  • Bug fix
  • Ts 类型更新
  • 打包优化
  • 性能优化
  • 功能增强
  • 重构
  • 依赖版本更新
  • 代码优化
  • 测试 case 更新
  • 分支合并
  • 网站/文档更新
  • demo 更新
  • Workflow
  • 配置修改
  • 发布
  • 其他 (具体是什么,请补充?)

🔗 相关 issue 连接

工作流生命周期回归,承接 #5345 的内部试点。本轮自动运行到等待人工批准,暂不合入。

💡 问题的背景&解决方案

已有 keyboard-select-all-body 只校验全选范围的首末行,漏选首列或末列时也可能通过。本次仅在 verify 中补齐首末列边界检查,保留原有 mount、exercise、数据及来源 ID;核心代码、交互操作和图片基准均不改变。

提交前验证:

  • 真实 ListTable 两个反例:漏选首列或末列时,旧断言通过、新断言正确拒绝。
  • 单例自比较 1/1,keyboard 目录 4/4。
  • 官方 develop(fa59fca)全量视觉 204/204,零差异、错误或跳过。
  • 正常 pre-push:8 个项目、1027 项单测通过。
  • Linux 固定运行包对原活动基准完整校准 204/204,宿主独立重算 204 组 PNG 通过;预期仅一个用例版本更新、零图片变更。

PR 创建后的正式 CI、Bot 审查、双执行器结果和计划,以本 PR 的 Checks 与 Bot 摘要为准。

📝 Changelog

仅增强测试覆盖,无对外行为变化。

Language Changelog
🇺🇸 English test: verify the first and last body columns in the keyboard select-all case.
🇨🇳 Chinese 测试:补齐键盘全选表体用例的首末列边界断言。

☑️ 自测

⚠️ 在提交 PR 之前,请检查一下内容. ⚠️

  • 文档提供了,或者更新,或者不需要
  • Demo 提供了,或者更新,或者不需要
  • Ts 类型定义提供了,或者更新,或者不需要
  • Changelog 提供了,或者不需要

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@visactor-review-bot

visactor-review-bot Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

VisActor 工作流结论:建议人工审阅后合入,并按计划更新资产

PR #5346 · generation 3 · 证据状态:current

  • head:b948c4718e214153b06eab6143e8ace209e57732
  • base:fa59fcacd530ab3de744616c4cf2da131584f8c0
  • 更新时间:2026-10-19T13:30:13.709Z
阶段 结果 依据 / 下一步
Build 通过 检查详情
Unit 通过 检查详情
Repository visual 通过 检查详情
BugServer 通过 本 PR 检查
CR 完整审查 开放阻断:0;零发现时不另发空 Review,审查状态以本摘要为准
Merge readiness 具备当前合入前证据 建议人工审阅后合入,并按计划更新资产

BugServer 执行范围

执行器 集合 匹配 差异 无基准 断言/执行错误 跳过/取消
Photo 完整 1 0 0 0 0
Playwright 完整 204 0 0 0 0

Photo 的语义断言、绘制和稳定性能力为 not_supported;其图片匹配不代表这些能力通过,也不代表旧 Photo 全数据集通过。Playwright 的执行检查须由完整原始结果验证。

资产计划

用例版本变更:1;基准变更:0。计划摘要:b6f46b1c0527e5f46ce7cfd85c8a8bb6165ebebccef7242279e216574742051d。本轮尚未发布资产。

其他仓库 CI 尚未通过

以下最多展示20项;完整状态请查看全部 Checks。

管理员下一步

有效资产计划已具备,请管理员核对变更范围并完成审阅。 本结论覆盖合入前;合入后资产发布与外部 PR 另行验收。

查看全部 Checks · 查看当前公开用例源码

{
  "schemaVersion": 1,
  "contractVersion": "1.0",
  "kind": "pr_status",
  "repository": "VisActor/VTable",
  "pullRequest": 5346,
  "generation": 3,
  "identity": {
    "repository": "VisActor/VTable",
    "productKey": "VTable",
    "pullRequest": 5346,
    "headSha": "b948c4718e214153b06eab6143e8ace209e57732",
    "baseSha": "fa59fcacd530ab3de744616c4cf2da131584f8c0",
    "baseRef": "develop",
    "controlCommit": "e3d0c438049be9bfd27483e439e0ad1f15fa6ee5",
    "subject": {
      "kind": "pr_head",
      "testedCommit": "b948c4718e214153b06eab6143e8ace209e57732",
      "mergeParents": [],
      "sourceDigest": "63daac24589e8a6971baa4b5cc5f56f561d27785464d0f766622c0d2b3825bd5"
    },
    "bundleDigest": "31e4ff17e42e97e180091929749c367d8f8b0653652f13ba8862f8fcb68c7769",
    "suiteDigests": {
      "photo": "70b6d5b15641b24702332bae8117cd25faf0c808d6d297280379bda727c259f3",
      "playwright": "899e9ff6b77a1f55898ff4bde68425f5f908df16a1b09076044f197498a0851d"
    },
    "environmentIds": {
      "photo": "sec01-linux-ae13ce92ad39b13fd8da1312-vtable-photo",
      "playwright": "sec01-linux-ae13ce92ad39b13fd8da1312-vtable"
    },
    "assetRevision": "5a625871884dd3939dab6746bbbf35a2e56f008523bc7780fd24d04d63284b91",
    "policyDigest": "553aabd58a4d0a852e6cca1699c008144f977f17990feb90938e234f5b69efcb"
  },
  "freshness": "current",
  "phase": "awaiting_merge",
  "requiredChecks": [
    {
      "key": "build",
      "status": "passed",
      "evidenceUrls": [
        "https://github.com/VisActor/VTable/runs/118083011063"
      ]
    },
    {
      "key": "unit",
      "status": "passed",
      "evidenceUrls": [
        "https://github.com/VisActor/VTable/runs/118083079886"
      ]
    },
    {
      "key": "repository_visual",
      "status": "passed",
      "evidenceUrls": [
        "https://github.com/VisActor/VTable/runs/118083135449"
      ]
    },
    {
      "key": "bugserver",
      "status": "passed"
    }
  ],
  "review": {
    "status": "completed",
    "coverage": "full",
    "blockingOpen": 0
  },
  "testSummaries": [
    {
      "engine": "photo",
      "rawOutcome": "passed",
      "complete": true,
      "counts": {
        "matched": 1,
        "different": 0,
        "no_baseline": 0,
        "assertion_failed": 0,
        "execution_error": 0,
        "skipped": 0,
        "cancelled": 0
      }
    },
    {
      "engine": "playwright",
      "rawOutcome": "passed",
      "complete": true,
      "counts": {
        "matched": 204,
        "different": 0,
        "no_baseline": 0,
        "assertion_failed": 0,
        "execution_error": 0,
        "skipped": 0,
        "cancelled": 0
      }
    }
  ],
  "mergeEligibility": "eligible",
  "recommendation": "merge_with_asset_update",
  "planSummary": {
    "planDigest": "b6f46b1c0527e5f46ce7cfd85c8a8bb6165ebebccef7242279e216574742051d",
    "caseChanges": 1,
    "baselineChanges": 0
  },
  "postMerge": {
    "state": "awaiting_merge",
    "publishJobId": null,
    "error": null
  },
  "nextActions": [
    {
      "actorRole": "maintainer",
      "actionCode": "review_and_merge",
      "reasonCode": "VALIDATED_ASSET_PLAN_REQUIRED_AT_MERGE",
      "text": "Maintainers can assess the current evidence and merge the PR.",
      "evidenceUrls": [
        "https://github.com/VisActor/VTable/pull/5346",
        "https://github.com/VisActor/VTable/runs/118083011063",
        "https://github.com/VisActor/VTable/runs/118083079886",
        "https://github.com/VisActor/VTable/runs/118083135449"
      ]
    },
    {
      "actorRole": "maintainer",
      "actionCode": "inspect_additional_check",
      "reasonCode": "ADDITIONAL_REPOSITORY_CHECK_NOT_PASSED",
      "text": "build  18.x :failure",
      "evidenceUrls": [
        "https://github.com/VisActor/VTable/runs/118061556613"
      ]
    }
  ],
  "acceptedAdvice": null,
  "updatedAt": "2026-10-19T13:30:13.709Z"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant