Repository navigation
Conversation
There was a problem hiding this comment.
审查冻结版本的多选区合并实现及选择状态调用链;发现表头仅选 body 模式下由表头交互产生的范围被误当普通 body 范围合并。既有讨论为空。
验证:阅读冻结 diff、选区状态、表头选择投影、场景图重建及公开配置契约;Node 标准库最小复现验证相邻表头投影两范围均被判为可合并,且连通并铺满外接矩形;未运行工程测试。
限制:冻结源码未安装依赖;未运行 Jest/Electron、完整工程测试或浏览器视觉回归。;仅运行 Node 标准库的源码条件简化复现,确认表头投影范围符合资格与矩形合并条件;未在真实 ListTable 环境执行该交互。;当前任务无 Checks/Actions/commit statuses 权限,未独立核验 PR 文本提及的 CI 状态。
状态:completed
There was a problem hiding this comment.
Latest reviewed commit: cdc9d70
No confirmed new issues found; both previously reported selection issues are fixed in the reviewed commit.
VisActor 工作流结论:PR 已关闭,流程结束PR #5320 · generation 6 · 证据状态:current
BugServer 执行范围
Photo 的语义断言、绘制和稳定性能力为 not_supported;其图片匹配不代表这些能力通过,也不代表旧 Photo 全数据集通过。Playwright 的执行检查须由完整原始结果验证。 资产计划尚无绑定当前身份的有效计划,不能据此认定合入前流程完成。 其他仓库 CI:当前未发现额外的未通过检查;仅说明本次查询结果。 管理员下一步本 PR 未合入,关闭不触发资产发布。 本结论覆盖合入前;合入后资产发布与外部 PR 另行验收。 {
"schemaVersion": 1,
"contractVersion": "1.0",
"kind": "pr_status",
"repository": "VisActor/VTable",
"pullRequest": 5320,
"generation": 6,
"identity": {
"repository": "VisActor/VTable",
"productKey": "VTable",
"pullRequest": 5320,
"headSha": "37cfa00f2784335b9f0999aee8feffc557a47fd4",
"baseSha": "9432ef78dc56f011c9175de64fc6cfdff2fd6825",
"baseRef": "develop",
"controlCommit": "e3d0c438049be9bfd27483e439e0ad1f15fa6ee5",
"subject": {
"kind": "pr_head",
"testedCommit": "37cfa00f2784335b9f0999aee8feffc557a47fd4",
"mergeParents": [],
"sourceDigest": "760ec2baa371a9ccfbeb0c2da761ac21b083b82772c6ffa57b56efbfd9671b8e"
},
"bundleDigest": "76f22e4b89d2c3e01edf2ca9ee15fd2220287d0b93203862fdc76b1498f6a851",
"suiteDigests": {
"photo": "81d6801e62f74000d05ccad21503ca3cae7cde20111eafb9f28bda0cb227f944",
"playwright": "9fc59d42da1e666da06ef3798544172ed3522e8c0756d73183c1f074a5394f1e"
},
"environmentIds": {
"photo": "sec01-linux-ae13ce92ad39b13fd8da1312-vtable-photo",
"playwright": "sec01-linux-ae13ce92ad39b13fd8da1312-vtable"
},
"assetRevision": "7155bae485e971b99121540dadd9448531661538999bccb03564bd749808fdfc",
"policyDigest": "553aabd58a4d0a852e6cca1699c008144f977f17990feb90938e234f5b69efcb"
},
"freshness": "current",
"phase": "closed",
"requiredChecks": [
{
"key": "build",
"status": "passed",
"evidenceUrls": [
"https://github.com/VisActor/VTable/runs/117385603405"
]
},
{
"key": "unit",
"status": "passed",
"evidenceUrls": [
"https://github.com/VisActor/VTable/runs/117385624571"
]
},
{
"key": "repository_visual",
"status": "passed",
"evidenceUrls": [
"https://github.com/VisActor/VTable/runs/117385648657"
]
},
{
"key": "bugserver",
"status": "passed"
}
],
"review": {
"status": "completed",
"coverage": "full",
"blockingOpen": 0
},
"testSummaries": [
{
"engine": "photo",
"rawOutcome": "passed",
"complete": true,
"counts": {
"matched": 1,
"different": 0,
"no_baseline": 0,
"assertion_failed": 0,
"execution_error": 0,
"skipped": 0,
"cancelled": 0
}
},
{
"engine": "playwright",
"rawOutcome": "passed",
"complete": true,
"counts": {
"matched": 204,
"different": 0,
"no_baseline": 0,
"assertion_failed": 0,
"execution_error": 0,
"skipped": 0,
"cancelled": 0
}
}
],
"mergeEligibility": null,
"recommendation": null,
"planSummary": null,
"postMerge": {
"state": "skipped_exception",
"publishJobId": null,
"error": null
},
"nextActions": [
{
"actorRole": "platform_maintainer",
"actionCode": "inspect_current_generation",
"reasonCode": "GENERATION_CLOSED_OR_SUPERSEDED",
"text": "This generation is closed or superseded. Use the current PR state; post-merge asset publication requires a verified plan.",
"evidenceUrls": [
"https://github.com/VisActor/VTable/pull/5320"
]
}
],
"acceptedAdvice": null,
"updatedAt": "2026-10-19T04:06:55.828Z"
} |
There was a problem hiding this comment.
Latest reviewed commit: 37cfa00
No confirmed new issues found.
🤔 This is a ...
🔗 Related issue link
None.
💡 Background and solution
Add opt-in
select.autoMergeRanges(defaultfalse) to merge adjacent or overlapping ordinary body selections when their connected union fills a rectangle. L-shaped, holed and disconnected selections retain their separate ranges. Header, row-series and frozen-partition selections are excluded.selectCellsevaluates the complete batch after per-range normalization and deduplication, including when the final input range is a duplicate. Ctrl selection and drag selection use the same merge routine. Selection borders andselected_cellpayloads reflect the final ranges.📝 Changelog
Validation
Regression coverage includes disabled behavior, adjacent/overlapping rectangles, L-shapes, holes, disconnected ranges, duplicate final ranges, Ctrl/event behavior, drag selection and frozen boundaries. Host validation details are recorded below. Product Electron tests must run in CI before review/merge; this remains a Draft PR.
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough
Supersedes #5319 with the same implementation commit, submitted from a branch in this repository so repository CI secrets are available.
Runner validation
Upstream CI verification