[MeijeGawinowski]

…itional parameters temin, temax, teopt and teoptbis

Please fill this pull request template by deleting and replacing the text.

---

Pull Request Name

Infos

Please find a step-by-step tutorial in the documentation about how to fill a pull request and ask for a review.

Description (to fill)

Please include a summary of the changes and what are the new features / which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

If it fixes a particular issue, use this keyword to reference it:

Fixes #{issue number}

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please list or describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

• Test A
• Test B

Test Configuration:

• R version:
• OS:
• Dependency versions (optionnal but recommended):

Reviewers

I explicitely ask for reviewers whenever possible, see the documentation for doing so.

Checklist for the reviewers:

• The code follows the style guidelines of this project
• The code is commented, particularly in hard-to-understand areas
• The documentation has been updated if necessary
• The changes generate no new errors, warnings or notes during the tests (package or CRAN tests)
• New tests have been added on the package to prove the fix is effective or the new feature works
• New and existing unit tests pass locally and remotely with those changes

If this pull request add breaking changes for other SticsRPacks packages:

• The team of the other package has been informed of the changes to come
• Another pull request has been proposed on their package to account for the potential impacts of the changes (optional)

[sbuis]

Hi,
I updated the tests and docs following your changes.
The regression test on model simulation is now the only one which fails. That is somehow expected since equations were modified. The test identified that the following variables were modified with respect to the reference: DELTAMS, DELTAMS_unstressed, MASEC, MASEC_unstressed

@MeijeGawinowski and @benjamindumontgxabt, is this behaviour expected?
If so, I will update the reference.

[benjamindumontgxabt]

@sbuis : To answer your questions, yes it is normal that DELTAMS, DELTAMS_unstressed, MASEC and MASEC_unstressed are modified with the addition of FTEMP.

[sbuis]

The model's non-regression is automatically checked by comparing its outputs against a reference generated from a previous run.

However, when a new process is added to the model, there is currently no automatic test to assess whether the implementation of that process is correct or meaningful.

@MeijeGawinowski and @benjamindumontgxabt, do you have ideas on how we could test the implementation of this new process?

[benjamindumontgxabt]

Now that I think about, and easy way to check it is to compare the new simulated final yield with "0.5*total biomass"

Some model do use a fix Harvest Index (+-0.5) that they apply on total biomass at the end of season, which gives the final yield.