Repository navigation
convolve: own the convolution-matrix helpers - #162
Merged
Merged
Conversation
conv_matrix_fill_sparsity / conv_matrix_fill_values build the Toeplitz matrix T(a) of convolve's 1D full convolution. convolve is their only caller, so they move here from sparsediff_linalg as static helpers (verbatim copies), and convolve no longer includes csr_kernels.h. This lets the library drop them from its public API. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conv_matrix_fill_sparsity/conv_matrix_fill_valuesbuild the Toeplitz matrix T(a) of convolve's 1D full convolution.convolve.cis their only caller, so they move here from sparsediff_linalg asstatichelpers.sparsediff_linalg/src/support/mini_numpy.c).convolve.cno longer includescsr_kernels.h.This lets sparsediff_linalg drop them from its public API (companion library PR). Merge order: this PR first. Against the library without them, engine
mainfails to compile inconvolve.c.Testing
nm:convolve.c.odefines both as local symbols in Debug and inlines them in Release. The engine library has no undefined_conv_matrix_*references.🤖 Generated with Claude Code