Repository navigation
Bump sparsediff_linalg to v0.5.0 - #164
Merged
Merged
Conversation
Pin the library at v0.5.0 (library PRs #21-#31) and migrate to its API. No behaviour change. - Vtable slots that became free functions: copy_sparsity -> copy_sparsity_matrices_alloc, DA_fill_values -> DA_matrices_fill_values, ATA_alloc / ATDA_fill_values -> ATA_matrices_alloc / ATDA_matrices_fill_values, transpose_alloc / transpose_fill_values -> transpose_matrices_*, block_left_mult_vec -> BA_kron_vec_matrices. - left_matmul's sparse kron branch (n_blocks > 1) calls BA_sparse_kron_matrices_*, which replaces the removed block_left_mult_sparsity / block_left_mult_values slots. - diag_vec's Jacobian is a row_reduce with group[i] = i*(n+1) and m_out = n*n, which replaces the removed diag_vec slots. - Includes: matmul_kron.h where kron dispatchers are called (left_matmul, bivariate_full_dom/matmul, quad_form); matmul.h for ATA/ATDA in elementwise_full_dom/common.c and the profiling harnesses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR pins
sparsediff_linalgto v0.5.0, up fromcba21ac(v0.4.0+29), and migrates the engine to the new API. Behaviour is unchanged. Follow-up refactors are in a separate PR stacked on this one.It takes in library PRs #21–#31. Most of them turned vtable slots into free functions:
X->copy_sparsity(X)copy_sparsity_matrices_alloc(X)(21 sites)X->DA_fill_values(d, X, C)DA_matrices_fill_values(d, X, C)J->ATA_alloc(J)/J->ATDA_fill_values(J, d, H)ATA_matrices_alloc/ATDA_matrices_fill_valuesblock_left_mult_sparsity/_valuesBA_sparse_kron_matrices_*(theleft_matmul.csparse kron branch)block_left_mult_vecBA_kron_vec_matricestranspose_alloc/transpose_fill_valuestranspose_matrices_*diag_vec_alloc/diag_vec_fill_valuesrow_reduce_*withgroup[i] = i*(n+1),m_out = n*n(as insum.c)Include changes:
matmul_kron.h(Prod axis one #30) inleft_matmul.c,bivariate_full_dom/matmul.candquad_form.c;matmul.hinelementwise_full_dom/common.cand in the two profiling harnesses.#21, #22, #23 and #25 need nothing here: they made library internals private or added new API, and #22's helpers already live in
convolve.c(#162).left_matmul.c'sJchild_CSC,J_CSCandcsc_to_csr_workare now unused. They are removed in the stacked follow-up PR.Testing
main.PROFILE_ONLY=ONbuilds.main, all inside the library.git grepfinds no remaining calls to the removed slots.🤖 Generated with Claude Code