Skip to content

Fix stale SMB secret + floating ansible-core in integ-run/integ-seq-run #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddemlow merged 1 commit into from
Nov 2, 2026
Merged

Fix stale SMB secret + floating ansible-core in integ-run/integ-seq-run #389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions .github/workflows/z_ansible-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,15 +63,26 @@ jobs:
shell: bash
run: |
[ "$X_GITHUB_SKIP_TEST" == "1" ] && exit 0
pip install -U ansible-core # ~=2.16.0
# Pinned to 2.16.0 (2026-11-02): matches examples-run's pin and Red Hat's
# partner-certification-checker v3.0.0 floor (>=2.16.0, #373). The prior
# "pip install -U ansible-core" silently floated to whatever's newest -- 2.17.4
# on this container -- which enforces strict boolean conditionals and broke ~15
# targets that use the bare-truthy-string idiom (#387). The comment here said
# "~=2.16.0" already; the command just never matched it.
pip install ansible-core~=2.16.0
ansible-galaxy collection install community.general community.crypto --force
ansible-galaxy collection list
# ${{ env.WORKDIR }} cannot be used in "uses:"
- uses: ./work-dir/ansible_collections/scale_computing/hypercore/.github/actions/make-integ-config
with:
sc_host: ${{ inputs.sc_host }}
sc_password_50: ${{ secrets.CI_CONFIG_HC_IP50_SC_PASSWORD }}
smb_password: ${{ secrets.CI_CONFIG_HC_IP50_SMB_PASSWORD }}
# 10.5.11.39's secret, CI_CONFIG_HC_IP50_SMB_PASSWORD, is kept for when PUB5/XLab
# returns. This call site was missed by the 2026-10-29 Indy-lab repoint (which only
# touched integ-test.yml's own make-integ-config calls) -- it was still sending the
# old PUB5 password against the new 10.6.42.5 server, which make-integ-config/action.yml
# hardcodes regardless of caller.
smb_password: ${{ secrets.CI_CONFIG_INDY_SMB_PASSWORD }}
oidc_client_secret: ${{ secrets.OIDC_CLIENT_SECRET }}
oidc_users_0_password: ${{ secrets.OIDC_USERS_0_PASSWORD }}
working_directory: ${{ env.WORKDIR }}
Expand Down
Loading