Repository navigation
Fix stale SMB secret + floating ansible-core in integ-run/integ-seq-run - #389
Merged
Merged
Conversation
…sible-core z_ansible-test.yml (the reusable workflow integ-run/integ-seq-run actually dispatch to) was missed by the 2026-10-29 Indy-lab repoint: it still passed CI_CONFIG_HC_IP50_SMB_PASSWORD to make-integ-config, which sends that password against the hardcoded 10.6.42.5 server -- a real access failure independent of the missing export/import directories (fixed separately, directly on the share). Also pin ansible-core to 2.16.0 instead of floating to latest (2.17.4 on the current container), matching examples-run's existing pin and Red Hat's partner-certification-checker v3.0.0 floor (#373). 2.17 enforces strict boolean conditionals and breaks ~15 targets using this collection's bare-truthy-string idiom (#387); 2.16 doesn't enforce it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bugs found while troubleshooting the nightly
vm_export/vm_import/remote_cluster_info-family CI failures on the Indy-lab fixture (vhc6 @ 10.6.112.64, vsns19 @ 10.6.42.19):integ-test.yml's ownmake-integ-configcalls to useCI_CONFIG_INDY_SMB_PASSWORD, but missed the call insidez_ansible-test.yml— the reusable workflowinteg-run/integ-seq-runactually dispatch to for each test target. That call site was still sendingCI_CONFIG_HC_IP50_SMB_PASSWORD(the old PUB5 password) against the new hardcoded10.6.42.5server, whichmake-integ-config/action.ymldoesn't vary by caller. This alone would 400 any SMB export/import regardless of directory state.pip install -U ansible-core # ~=2.16.0— the comment said one thing, the actual command did another. On the currentself-hosted2container that resolved to 2.17.4, which enforces strict boolean conditionals and breaks ~15 integration targets using this collection's bare-truthy-string idiom (Bare non-empty-string conditionals break under ansible-core 2.17.4 (~28 sites, 3 already fixed) #387). Pinned toansible-core~=2.16.0, matchingexamples-run's existing pin and Red Hat'spartner-certification-checkerv3.0.0 floor (Reconcile Ansible-core/Python version requirements (currently inconsistent, and behind Red Hat's certification checker v3.0.0) #373, which requires>=2.16.0and doesn't test anything older).Also created the missing SMB subdirectories directly on the
10.6.42.5/exportsshare (integration-test-vm-export,integration-test-vm-import-vhc6,integration-test-vm-import-vsns19) — the old10.5.11.39/cidatashare had these from years ago; the repoint moved to a brand-new share that was never populated with them, and HyperCore's export/import API doesn't auto-create the target directory. That's an infra-side fix (not in this diff), noted here for context since it was failing for the same symptom.Test plan
integ-testrun (or a manualworkflow_dispatch) showsvm_export/vm_importpassing on both10.6.112.64and10.6.42.19#387-family bare-conditional failures (node_info,registration,inventory,time_zone,time_server,snapshot_schedule,role_template2vm,dns_config,smtp,utils_login,role_cluster_config,vm_snapshot,vm_clone,vm_disk__iso_eject,version_update__shutdown_restart_vms,remote_cluster_info) stop failing with the 2.16.0 pin🤖 Generated with Claude Code