Repository navigation
Move the rack into the package: vrack becomes audioinstruments._rack; 0.5.0.dev2 - #32
Merged
Merged
Conversation
lib/vrack moves to lib/audioinstruments/_rack, so the wheel and a frozen build ship one package. Imports, module paths and docs follow; prose that named the package now says the rack. VERSION moves to 0.5.0.dev2 and every face is regenerated with it.
A kit declares PADS, (key, voice) pairs, not NOTE_MAP, so its face had no note map and _names.py listed it as melodic. make_faces now names each pad from the kit's VOICE_NAMES (a sound on several keys is numbered, as General MIDI does), and the kits declare the Drum category. The nine instruments without a DISPLAY_NAME take their class name. The MicroPython face test plays a kit on its own voices and its first pad.
The move wrote the package's dotted name where three tests join a path into lib/, so two of them looked for lib/audioinstruments._rack and the allocation test reported its frames from the wrong root. The rack panel's title says rack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/vrack moves to lib/audioinstruments/_rack. A wheel or a frozen build now ships one package,
audioinstruments, with the rack under it as a private subpackage; the instruments by name stay the public surface.import audioinstruments._rack.adapter as adapter,from audioinstruments._rack import Rack.audioinstrumentsalone; the rack comes with it.audioinstruments/_rack/__init__.py.A second commit fixes the drum kits' faces: a kit declares
PADS, notNOTE_MAP, so its face had no note map andDRUM_MACHINESwas empty. make_faces now names each pad from the kit'sVOICE_NAMES, the kits declare the Drum category, and the nine instruments without aDISPLAY_NAMEtake their class name.Checked: ruff on lib, tests, examples and tools; the face, CI-scope, core, adapter, lazy-import and drum tests (434 passed); the MicroPython tests on a unix build (256, no failures).
Replaces #26, which was cut before the drum machines landed.