Repository navigation
Conversation
lib/vrack moves to lib/audioinstruments/_rack, so the wheel and a frozen build ship one package. Imports, module paths and docs follow; prose that named the package now says the rack. The faces are unchanged apart from the module each one names as its source.
Contributor
Author
|
Replaced by #32, cut on main after the drum machines landed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/vrack moves to lib/audioinstruments/_rack. A wheel or a frozen build now ships one package,
audioinstruments, with the rack under it as a private subpackage; the instruments by name stay the public surface.import audioinstruments._rack.adapter as adapter,from audioinstruments._rack import Rack.audioinstrumentsalone; the rack comes with it.audioinstruments/_rack/__init__.py.Checked: ruff on lib, tests, examples and tools; the face, CI-scope, core, adapter, lazy-import and graph tests (171 passed); the MicroPython tests on a unix build (217, no failures); a wheel holds
audioinstruments/_rack/and novrack/.Draft until the open drum machine PRs land, so they don't need rebasing across the move.