Repository navigation
audiosampler: no float == in CircuitPython's SamplerVoice binding - #357
Merged
Merged
Conversation
CircuitPython's esp32 ports build with -Werror=float-equal, and the binding compared the depth with != 0.0f, so every CircuitPython board build stopped at SamplerVoice.c since #337.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CircuitPython's esp32 ports compile with
-Werror=float-equal.SamplerVoice.vibrato_depth's setter compared the depth with!= 0.0f, so every CircuitPython board build (LCD-7, LCD-4.3, T-Watch, the P4 DEV-KIT) stops atSamplerVoice.c:401since #337. The shared kernels already build with the warning off for their own objects (circuitpython.mk); this binding isn't one of them, so the test becomescents < 0.0f || cents > 0.0f, which is the same for every number.Found by micropython-pydevices' firmware builds at the v0.6.12 pin.