Repository navigation
Pin audiodsp at its CircuitPython build fix; a pin change builds the firmware set - #239
Merged
Merged
Conversation
…firmware set audiodsp v0.6.12 stops every CircuitPython board build at SamplerVoice.c (-Werror=float-equal); audiodsp#357 fixes it. Nothing caught it because a change to modules.lock or deps.lock didn't run the firmware builds on its PR. Now it runs them all.
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
audiodsp v0.6.12, pinned in #236, stops every CircuitPython board build at
SamplerVoice.c:401(-Werror=float-equal). audiodsp#357 fixes it; this pins audiodsp at that merge, c2495f4, which is on main but not yet in a release.Nothing caught the break because a change to
modules.lockordeps.lockdidn't run the firmware builds on its pull request; only Monday's scheduled run would have. Now both files are inrelease-firmware.yml's pull-request paths, andci_scope.firmware_scopebuilds the whole set for either, with a test for each. This PR's own CircuitPython cells are the proof of the fix.test_ci_scope,test_release_firmwareandtest_stage_firmware_pagepass locally (59 tests).