Repository navigation
feat(cli)!: take --local-registry, --remote-registry and --auto-build - #669
Merged
Merged
Conversation
This was referenced Nov 4, 2026
karhu
force-pushed
the
tnet-157/16-cli-flags
branch
from
November 5, 2026 07:24
8ca6084 to
9cda287
Compare
karhu
force-pushed
the
tnet-157/16-cli-flags
branch
from
November 5, 2026 08:16
9cda287 to
098dc45
Compare
karhu
force-pushed
the
tnet-157/16-cli-flags
branch
from
November 5, 2026 10:57
098dc45 to
23292cc
Compare
karhu
force-pushed
the
tnet-157/16-cli-flags
branch
from
November 5, 2026 14:05
23292cc to
7d61be1
Compare
karhu
force-pushed
the
tnet-157/16-cli-flags
branch
from
November 7, 2026 15:20
d64e5e4 to
cad0ed0
Compare
karhu
force-pushed
the
tnet-157/16-cli-flags
branch
from
November 7, 2026 16:27
cad0ed0 to
59eb3e3
Compare
karhu
force-pushed
the
tnet-157/16-cli-flags
branch
from
November 7, 2026 17:40
59eb3e3 to
0e9d806
Compare
karhu
force-pushed
the
tnet-157/16-cli-flags
branch
2 times, most recently
from
November 7, 2026 22:40
0d0234d to
3fd4fd8
Compare
karhu
force-pushed
the
tnet-157/16-cli-flags
branch
from
November 9, 2026 13:56
3fd4fd8 to
1d20f8f
Compare
karhu
force-pushed
the
tnet-157/16-cli-flags
branch
from
November 9, 2026 16:18
1d20f8f to
85c5a3c
Compare
karhu
force-pushed
the
tnet-157/16-cli-flags
branch
from
November 10, 2026 14:39
85c5a3c to
56dd4be
Compare
karhu
force-pushed
the
tnet-157/16-cli-flags
branch
from
November 10, 2026 15:50
56dd4be to
c1291e6
Compare
karhu
force-pushed
the
tnet-157/16-cli-flags
branch
from
November 10, 2026 16:24
c1291e6 to
71a370c
Compare
There was a problem hiding this comment.
An organization admin can review the limit in your organization's usage and billing settings.
Once the limit resets or is raised, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
The consumer CLI had one flag for the list of sources: --registry named the registry after the local registry. The local registry and the installed connectors came only from the environment, so a command could not move the local registry or leave out the connectors. Now list, search, info and download take three flags, one for each variable of the default list. --local-registry places the local registry, --remote-registry names the registry after it, and --auto-build/--no-auto-build puts the installed connectors last or leaves them out. Each flag overrides its variable. If a flag is not given, the variable applies. The commands make the list with default_sources(), so an empty value raises TimeFValidationError and never means the current directory. The error names the variable and, if the variable has one, its flag. timenet local info and timenet local clear take only --local-registry, because they work on the local registry and the cache alone. timenet local cache info and clear take no flag. The flags are in the new module timenet.cli.options, so that the build CLI can take the same flags with the same help. BREAKING CHANGE: timenet list, search, info and download take --local-registry, --remote-registry and --auto-build/--no-auto-build instead of --registry. Part of TNET-157.
Shorter docstrings for the code that this change adds or changes. Part of TNET-157.
Drop tests that cannot fail or repeat other tests, and sharpen the rest. Part of TNET-157.
karhu
force-pushed
the
tnet-157/16-cli-flags
branch
from
November 10, 2026 17:41
71a370c to
29cb245
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Stack
This stack covers refactoring the internal logic of how releases are resolved during read, download & build, in particular also in the context of parent releases / parent datasets. On top of that it refactors the public TimeNet APIs and CLI interfaces around these actions, to streamline the behavior across them.
This PR
timenet list,search,infoanddownloadtake--local-registry,--remote-registryand--auto-build/--no-auto-build. They replace--registry.Details
The consumer CLI had one flag for the list of sources:
--registrynamed the registry after the store. The store and the installed connectors came only from the environment, so a command cannot move the store or leave out the connectors.default_sources(). An empty value raisesTimeFValidationErrorand never means the current directory. The error names the variable. If the variable has a flag, the error names the flag too.timenet local infoandtimenet local cleartake only--local-registry, because they work on the store and the cache alone.timenet local cache infoandtimenet local cache cleartake no flag.timenet.cli.options, so that the build CLI can take the same flags with the same help.Design decisions
default_sources()and not their own parsing, so a flag and its variable follow the same checks.local infoandlocal cleartake no other flags, because they never read a registry after the store.Breaking changes
timenet list,search,infoanddownloadtake--local-registry,--remote-registryand--auto-build/--no-auto-buildinstead of--registry.timenet local infoandtimenet local cleartake--local-registry.Stack
Changes later in the stack:
timenet-build buildstill takes--out,--fetch-fromand--build-parents. The PR ontimenet-build --publish-toreplaces them with these flags.Merge message