Repository navigation
refactor(coordinator)!: name the plan step type Step - #651
Merged
Merged
Conversation
This was referenced Nov 3, 2026
karhu
force-pushed
the
tnet-157/4-plan-steps
branch
from
November 3, 2026 22:47
2445c0a to
7588d78
Compare
This was referenced Nov 3, 2026
karhu
force-pushed
the
tnet-157/4-plan-steps
branch
from
November 4, 2026 12:01
ca5ebf3 to
dacdc64
Compare
This was referenced Nov 4, 2026
karhu
marked this pull request as ready for review
November 4, 2026 12:30
✅ CI checks passed
Updated for |
karhu
force-pushed
the
tnet-157/4-plan-steps
branch
from
November 4, 2026 12:42
dacdc64 to
f5d2401
Compare
This was referenced Nov 4, 2026
TimoStoff
reviewed
Nov 4, 2026
TimoStoff
reviewed
Nov 4, 2026
TimoStoff
reviewed
Nov 4, 2026
TimoStoff
left a comment
Contributor
There was a problem hiding this comment.
The action is now "copy", but the module still says "fetch" everywhere else: the fetch_from parameter, the fetched set on the graph, and a ton of docstrings that say "the plan fetches". fetch_from is also the CLI flag. Should we make that naming consistent?
TimoStoff
approved these changes
Nov 4, 2026
karhu
force-pushed
the
tnet-157/4-plan-steps
branch
from
November 4, 2026 20:02
f5d2401 to
2f3319f
Compare
karhu
force-pushed
the
tnet-157/4-plan-steps
branch
from
November 6, 2026 07:54
c045ec8 to
aa45819
Compare
karhu
force-pushed
the
tnet-157/4-plan-steps
branch
from
November 6, 2026 13:54
aa45819 to
ed48a5e
Compare
karhu
force-pushed
the
tnet-157/4-plan-steps
branch
from
November 7, 2026 15:23
ed48a5e to
35dd471
Compare
RealLast
requested changes
Nov 9, 2026
RealLast
approved these changes
Nov 10, 2026
RealLast
left a comment
Contributor
There was a problem hiding this comment.
As discussed, accepting to unblock : ) We can clean up later
karhu
force-pushed
the
tnet-157/4-plan-steps
branch
from
November 10, 2026 14:39
35dd471 to
b11d54f
Compare
karhu
force-pushed
the
tnet-157/4-plan-steps
branch
from
November 10, 2026 15:50
b11d54f to
0ed1f41
Compare
karhu
force-pushed
the
tnet-157/4-plan-steps
branch
from
November 10, 2026 16:24
0ed1f41 to
4cbfda2
Compare
The planner now calls its step type Step. It also adds a Plan type that holds the steps. A step has a release field instead of reference. The action "fetch" is now "copy". Each step lists in depends_on the releases of the plan that must be in place before it runs. Part of TNET-157.
Say only what a caller of the plan steps needs to know. Part of TNET-157.
…ports No code on this branch returns a Plan, so the type goes away until the build coordinator returns one. A ruff rule (banned-api) now refuses an import of timenet_connectors in the code of the timenet package. So the subprocess test that the planner imports nothing from timenet_connectors goes away. The test of the Plan and Step dataclasses and a test that repeated a case of the parametrized plan test go away too. The error for a registry source with an output that is not local now says "copying parents from a registry", the term of the plan steps. Part of TNET-157.
Shorter docstrings for the code that this change adds or changes. Part of TNET-157.
karhu
force-pushed
the
tnet-157/4-plan-steps
branch
from
November 10, 2026 17:41
4cbfda2 to
32ee397
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Stack
This stack covers refactoring the internal logic of how releases are resolved during read, download & build, in particular also in the context of parent releases / parent datasets. On top of that it refactors the public TimeNet APIs and CLI interfaces around these actions, to streamline the behavior across them.
This PR
Renames
ParentSteptoStep, so that the parent planner and the coordinator use the same step type.Details
This PR is mostly a cleanup. The parent planner already works with
ParentStepobjects, and the coordinator will use steps as well. This PR consolidates the two.ParentStepbecomesStep(release, action, depends_on, pinned_by)."fetch"becomes"copy", the word that the copy function and the progress events use.depends_onlists the releases of the plan that must be in place before the step runs. A dependency that the output already holds has no step, so it is not listed.Design decisions
depends_onnames every release that needs it.Stepgets more fields later in the stack (the entry that provides a release, aforceflag, and a"read"action). All are additions.Breaking changes
Stack
Changes later in the stack: nothing in this PR.
Merge message