Repository navigation
Replace apt-key in IntelLLVM clang workflow - #261
Merged
Merged
Conversation
ubuntu-latest now resolves to ubuntu-26.04, which no longer ships apt-key, so the "Add Intel repository" step failed with "sudo: 'apt-key': command not found" for every matrix entry. Store the dearmored Intel key in a dedicated keyring and reference it via signed-by in the oneAPI APT source, as recommended by the oneAPI installation guide. This also drops the dependency on add-apt-repository.
antonwolfy
requested review from
jharlow-intel,
ndgrigorian,
vlad-perevezentsev and
xaleryb
as code owners
October 28, 2026 10:10
This was referenced Oct 28, 2026
vlad-perevezentsev
approved these changes
Oct 29, 2026
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ubuntu-latestnow resolves to theubuntu-26.04image, which no longer shipsapt-key. As a result the Add Intel repository step ofbuild-with-clang.ymlfails for every Python version in the matrix:Example: https://github.com/IntelPython/mkl-service/actions/runs/40669327603/job/122751807638 (seen on #259).
This PR keeps the job on
ubuntu-latestand switches to the keyring approach recommended by the oneAPI APT installation guide:/usr/share/keyrings/oneapi-archive-keyring.gpg/etc/apt/sources.list.d/oneAPI.listwithsigned-by=pointing to that keyring, soadd-apt-repositoryis no longer neededTest plan
pre-commit(including actionlint) passes on the changed workflowE9BF0AFC46D6E8B7DA5882F1BAC6F0C353D04109, valid until 2027-08-21)Build project with IntelLLVM clang compileris green for the whole matrix on this PR