Repository navigation
ci: add the Intel apt key without apt-key - #266
Closed
jharlow-intel wants to merge 1 commit into
Closed
jharlow-intel wants to merge 1 commit into
jharlow-intel wants to merge 1 commit into
Conversation
apt-key is no longer on the ubuntu-latest image. Dearmor the key into /usr/share/keyrings and reference it with signed-by, as dpnp and dpctl do.
jharlow-intel
requested review from
antonwolfy,
ndgrigorian,
vlad-perevezentsev and
xaleryb
as code owners
October 28, 2026 22:03
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the Intel apt repository signing-key update.
No open issues 🎉
What changed in this PR
Updates the Clang CI workflow to configure Intel’s apt repository without the removed apt-key command.
Changes:
- Uses Intel’s current public signing-key file.
- Converts the key with
gpg --dearmorand restricts its use to the Intel repository throughsigned-by.
Repository guidance could not be loaded because /repo/AGENTS.md was unavailable.
| File | Description |
|---|---|
.github/workflows/build-with-clang.yml |
Replaces apt-key with a dedicated keyring and a signed repository entry. |
Review effort: Balanced
vchamarthi
approved these changes
Oct 28, 2026
vchamarthi
left a comment
vchamarthi
left a comment
Contributor
There was a problem hiding this comment.
LGTM: the Intel apt key now goes into a keyring with signed-by, all 8 build-with-clang legs pass, and no other file in the repo uses apt-key
Collaborator
|
That already covered by #261 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apt-keyis gone from theubuntu-latestimage, sobuild-with-clang.ymlfail at "Add Intel repository" withsudo: 'apt-key': command not foundon every pull request (build-with-clang).This adds Intel's apt key with
gpg --dearmorinto/usr/share/keyrings/oneapi-archive-keyring.gpgand points the source at it withsigned-by, as Intel's install guide, dpnp and dpctl do. It also moves to the current key file,GPG-PUB-KEY-INTEL-SW-PRODUCTS.PUB, which they use.