Repository navigation
fix: Write device.yml with owner-only permissions - #825
Merged
Merged
Conversation
The agent now creates device.yml with mode 0600 and sets that mode when the file is rewritten in place. Failing to change the mode of a file owned by another user is logged and ignored.
Contributor
|
Tagging Steve as well to test on Windows as I can't get to my windows box from here |
hardillb
approved these changes
Nov 13, 2026
Contributor
Author
|
I will wait for @Steve-Mcl 's approval too |
Steve-Mcl
approved these changes
Nov 13, 2026
Steve-Mcl
left a comment
Contributor
There was a problem hiding this comment.
tested on windows - no issues with changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The agent rewrites
device.ymlwith mode0600.0600. This is the usual path, because the old file is first renamed to a backup.fchmodon it. If that fails, for example with EPERM on a file owned by another user, the error is logged and the write goes ahead.Tests cover both paths. They are skipped on Windows.