Repository navigation
fix: Write project settings.json with owner-only permissions - #826
Merged
Merged
Conversation
The launcher now creates settings.json with mode 0600 and sets that mode when an existing file is rewritten. Failing to change the mode of a file owned by another user is logged and ignored.
hardillb
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #825. The launcher writes
project/settings.jsonwith mode0600, the same asdevice.yml.0600.chmod 0600. If that fails, for example with EPERM on a file owned by another user, the error is logged and the write goes ahead.A test covers both the new file and the rewrite. It is skipped on Windows.