Repository navigation
chore(ingress): remove unreachable code - #160
Merged
Merged
Conversation
kvinwang
force-pushed
the
fix/ingress-issue-retry
branch
from
October 16, 2026 01:09
cd0d500 to
140173f
Compare
kvinwang
force-pushed
the
chore/ingress-dead-code
branch
2 times, most recently
from
October 16, 2026 01:20
8912503 to
30a2624
Compare
kvinwang
force-pushed
the
fix/ingress-issue-retry
branch
from
October 16, 2026 01:20
140173f to
829d9fa
Compare
kvinwang
force-pushed
the
chore/ingress-dead-code
branch
from
October 16, 2026 01:20
30a2624 to
1c7c6ae
Compare
kvinwang
force-pushed
the
fix/ingress-issue-retry
branch
from
October 16, 2026 01:20
829d9fa to
ec5a04b
Compare
kvinwang
force-pushed
the
chore/ingress-dead-code
branch
from
October 16, 2026 01:23
1c7c6ae to
f46c7da
Compare
kvinwang
force-pushed
the
fix/ingress-issue-retry
branch
from
October 16, 2026 01:23
ec5a04b to
4f30b0a
Compare
kvinwang
force-pushed
the
chore/ingress-dead-code
branch
from
October 16, 2026 01:25
f46c7da to
0694bf5
Compare
kvinwang
force-pushed
the
fix/ingress-issue-retry
branch
from
October 16, 2026 01:25
4f30b0a to
88b936b
Compare
- sanitize_client_max_body_size, sanitize_proxy_timeout, sanitize_proxy_buffer_size and sanitize_proxy_buffers are left over from the nginx days; only their tests called them. entrypoint.sh just warns that those settings are ignored. - The `*)` branch of the final CHALLENGE_TYPE dispatch in entrypoint.sh cannot run: the value is validated at the top of the script. Signed-off-by: Kevin Wang <wy721@qq.com>
kvinwang
force-pushed
the
chore/ingress-dead-code
branch
from
October 16, 2026 01:27
0694bf5 to
f16106b
Compare
kvinwang
force-pushed
the
fix/ingress-issue-retry
branch
from
October 16, 2026 01:27
88b936b to
d651b61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sanitize_client_max_body_size,sanitize_proxy_timeout,sanitize_proxy_buffer_size,sanitize_proxy_buffers: nginx leftovers only their tests called;entrypoint.shjust warns those settings are ignored.*)branch of the finalCHALLENGE_TYPEdispatch: the value is validated at the top ofentrypoint.sh.Stacked on #159 only to avoid a conflict in
functions.shwith #156.