Repository navigation
refactor(ingress): share the certificate pass between modes - #156
Merged
Merged
Conversation
run_pass, cert_loop, collect_evidence, build_combined_pems and the FIRST_PASS/APPLY_PENDING state were copied in dns01.sh and tlsalpn.sh, and cert_loop had already drifted. Move them into cert-lib.sh; each mode now only supplies process_domain, the certificate paths and acme_account_file. No behaviour change. Signed-off-by: Kevin Wang <wy721@qq.com>
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
run_pass,cert_loop,collect_evidence,build_combined_pemsand the pass state were copied indns01.shandtlsalpn.sh, andcert_loophad already drifted. The next fixes (#157, #158, #159) would otherwise have to be made twice.What
Move them into
scripts/cert-lib.sh. Each mode suppliesprocess_domain,cert_fullchain_path/cert_privkey_pathandacme_account_file(replacesget_letsencrypt_account_file). No behaviour change.Tests
Unit tests (74) and
test_sanitizers.shpass;shellcheckshows no new findings. End-to-end run on Pebble for the whole stack is in progress; results will follow in a comment.First of a stack: this → #157 → #158 → #159 → #160.