Repository navigation
Rewrite dc_sim - #404
Open
pblowey wants to merge 13 commits into
Open
Rewrite dc_sim#404pblowey wants to merge 13 commits into
pblowey wants to merge 13 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main motivation is to migrate dc_sim away from using db_server in favour of ispyb-api calls. Old dc_sim code was complicated and had features that are no longer used anymore, including options for em data and pre-defined scenario datasets.
New code is now self contained in the wrapper. Usage is to call the recipe via
zocalo.go -r dc_sim 123456where the recipe is called against an existing data collection, allowing normal ispybtbx queries for that data collection to be used. Other options can be passed as arguments using -s, which include:copy_dcg- If set to True, this will simulate the entire data collection group that the data collection is in.dest_visit- Override the default destination visit for simulated data.Processing requests are then made to mimas by sending messages to the next step in the recipe.
PR also removes old dc_sim code from the repository.
Relies on recipe changes in https://gitlab.diamond.ac.uk/scisoft/zocalo/-/merge_requests/221