You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[ElasticSan] Support for 2026-05-01-preview service version - #10462
cmd elastic-san volume-group update update parameter protocol_type: updated property choices from ['Iscsi', 'None'] to ['DirectAttach', 'Iscsi', 'None']
This PR adds warning or check suppressions. Fix the underlying warning where possible and justify each remaining suppression in a code comment or the PR description.
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.
Update Elastic SAN commands to use the 2026-05-01-preview API and add V2 capacity and performance support.
Add V2 autoscale defaults: enable autoscale, default the increase and unused-size threshold to 1 TiB, and derive the scale-up ceiling from the SAN size and regional SKU capability. The service team confirmed that CLI should follow these defaults when these parameters are not specified.
Add volume-group QoS and reservation options, encryption in transit at creation, and support for the DirectAttach protocol.
Preserve generic update options and legacy identity behavior. Use GET-modify-PATCH for supported updates and GET-modify-PUT for SAN SKU and availability-zone edits.
Add managed-by compatibility handling and permanent volume-delete support.
Set the preview extension version to 2.0.0b1.
Breaking Change
Volume output managedBy changes from an object containing resourceId to an array of objects containing resourceIds. Existing queries using managedBy.resourceId must be updated.
The new managedByResourceId compatibility alias returns the first resource ID; it cannot represent additional IDs or preserve the old query path.
Test evidence (as of 11/10)
azdev style azext_elastic_san — passed: pylint and flake8.
azdev test azext_elastic_san --live --series -a -k test_elastic_san_v2_scenarios — passed. Covers V2 SAN operations and PerformanceCritical volume-group reservations.
azdev test azext_elastic_san --series -a -k test_elastic_san_v2_scenarios — passed in playback.
azdev test azext_elastic_san --live --series -a -k test_elastic_san_v2_autoscale_defaults — passed. Covers V2 creation with autoscale options omitted.
azdev test azext_elastic_san --series -a -k test_elastic_san_v2_autoscale_defaults — passed in playback.
Focused compatibility unit tests — 55 passed, 255 subtests passed; four profile-dependent tests were deselected because the sandbox blocked access to the Azure profile.
Requiring identity.type breaks previously valid partial updates such as --identity '{user-assigned-identity:<id>}' on a group that already has a user-assigned identity: validation now fails before GET can preserve the existing type. Keep the type optional and resolve an omitted type from the retrieved identity before translating the legacy options. Add a regression test for this partial-update form.
Thanks for all the iterations. CI is green, and the --remove and legacy --identity findings look addressed. A few items before approval:
Release packaging: HISTORY declares a breaking managedBy output change (object → array). Per the extension versioning guidelines, this preview should be 2.0.0b1, not 1.4.0b1. Please also align azext.isPreview with the preview release.
PR description and source: Please add a summary, links to the merged REST spec and Azure/aaz#1119, the breaking output change and managedByResourceId compatibility alias, and test evidence. Please coordinate review and merge of the AAZ source changes.
Service readiness: The scenarios use the East US 2 EUAP ARM endpoint. Please confirm that 2026-05-01-preview is available through public ARM in the supported regions, since existing commands also switch to this version.
Two implementation questions:
AAZ compatibility overrides: Can the generator preserve generic-update support and reduce the custom overrides? If these overrides are necessary, please briefly document the non-obvious compatibility workarounds.
V2 autoscale defaults: Please confirm that the CLI-side defaults and additional SKU-discovery request are agreed with the service team, document the defaults in command help, and add a recorded scenario exercising creation with those defaults omitted.
Release packaging: HISTORY declares a breaking managedBy output change (object → array). Per the extension versioning guidelines, this preview should be 2.0.0b1, not 1.4.0b1. Please also align azext.isPreview with the preview release.
Latest commit contains changes to 2.0.0b1 version and azext.IsPreview set to true.
PR description and source: Please add a summary, links to the merged REST spec and Azure/aaz#1119, the breaking output change and managedByResourceId compatibility alias, and test evidence. Please coordinate review and merge of the AAZ source changes.
Updated PR description (at the bottom) with all the asked information
Service readiness: The scenarios use the East US 2 EUAP ARM endpoint. Please confirm that 2026-05-01-preview is available through public ARM in the supported regions, since existing commands also switch to this version.
I can follow up on this. I was told by the service team that the supported version was only available in East US 2 EUAP, however that may have changed. However they were the ones who requested for a CLI extension support for this latest version.
Two implementation questions:
AAZ compatibility overrides: Can the generator preserve generic-update support and reduce the custom overrides? If these overrides are necessary, please briefly document the non-obvious compatibility workarounds.
The compatibility overrides are needed because the regenerated PATCH commands don't provide the old generic-update flow, and also the PATCH command doesn't accept SKU or availability zones. Also some of the compatability overrides handle the legacy identity and managed by formats. I updated the docs for the non-obvious workarounds in the readme. AAZ can update some commands but I did not find that it could address the compatibility flow.
V2 autoscale defaults: Please confirm that the CLI-side defaults and additional SKU-discovery request are agreed with the service team, document the defaults in command help, and add a recorded scenario exercising creation with those defaults omitted.
So the service team were the ones who called this out to set the V2 autoscale defaults, and matching SKU for regional limits. I updated the docs to reflect this, and also added a recorded scenario for creation with the defaults omitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation —⚠️ Review suggested
This PR adds warning or check suppressions. Fix the underlying warning where possible and justify each remaining suppression in a code comment or the PR description.
1 added suppression
src/elastic-san/azext_elastic_san/custom.pyclass _InstanceUpdateByGeneric(AAZGenericInstanceUpdateOperation): # pylint: disable=too-few-public-methodsThis checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.Summary of Changes
Related PR links:
Merged REST Spec PR: Azure/azure-rest-api-specs#41534
AAZ PR: Azure/aaz#1119
2026-05-01-previewAPI and addV2capacity and performance support.DirectAttachprotocol.2.0.0b1.Breaking Change
Volume output
managedBychanges from an object containing resourceId to an array of objects containingresourceIds. Existing queries usingmanagedBy.resourceIdmust be updated.The new
managedByResourceIdcompatibility alias returns the first resource ID; it cannot represent additional IDs or preserve the old query path.Test evidence (as of 11/10)