Repository navigation
[ElasticSan] Adding support for 2026-05-01-preview service version - #1119
Ethan Yang (necusjz) merged 4 commits into
Conversation
|
JaysonTaiMicrosoft Do you know who I can contact about getting this PR reviewed and merged? |
Naga Nandyala (naga-nandyala)
left a comment
There was a problem hiding this comment.
Thanks. Before approving, this needs to match the code generated in Azure/azure-cli-extensions#10462. The extension's generated files changed after this PR's last commit (10/13) and no longer match these models. For example, --total-size-tib help says "TiB" and "Settable only for ElasticSanVersion V2, where it is required; read-only for V1" in the extension but "TB" / "Supported only for ElasticSanVersion V2" here, and volume list help says "volumes" in the extension but "volume groups" here. Please make those changes in the AAZ models, push them here, and regenerate the extension from this branch so the two match exactly.
Also, per the open questions on #10462: if generic-update support or the -a/-d short options can be set in the models, please make those changes here rather than with overrides in custom.py. Consider making --access-soft-deleted-resources the primary option instead of the header-derived --x-ms-access-soft-deleted-resources. We'll review and merge this together with #10462.
update.
please provide the link to the corresponding pull request in Azure/azure-cli or Azure/azure-cli-extensions: Azure/azure-cli-extensions#10462