Repository navigation
fix(ci): keep Cypress readiness checks working on Node 24 - #4387
Conversation
Runner 2.338.0 upgrades the action runtime from Node 24.19.0 to 24.21.0. The got@11 client in Cypress action v7.3.0 crashes on an initial refused connection with Node 24.20.0 and later, before http-server can start. Update all three action references to SHA-pinned v7.4.4, which fixes the readiness check by upgrading got. Upstream: cypress-io/github-action#1874
olemartinorg
added
kind/bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly identifies the CI fix and explains the main change: keeping Cypress readiness checks working with Node 24. |
| Description check | |
The description explains the failure, affected Cypress action references, upstream fix, affected branches, and verification decisions. It follows the required sections. The related issue section lists… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Description check
-
Explanation
The description explains the failure, affected Cypress action references, upstream fix, affected branches, and verification decisions. It follows the required sections. The related issue section lists relevant links but does not use the requested closing-issue format, and sprint-board and label status remain unchecked.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Description
Cypress CI can now wait for the frontend server to start on GitHub runner 2.338.0. That runner upgrades the action's Node runtime from 24.19.0 to 24.21.0, exposing a bug in the HTTP client bundled with Cypress action v7.3.0. The readiness check fails immediately with
Socket closed before the connection was established, before tests run.Update all three action references to SHA-pinned v7.4.4, which includes the upstream fix. Both main and release/v4.35 use the affected pin.
Related Issue(s)
Verification/QA
Manual functionality testing
Automated tests
UU/WCAG (follow these guidelines until we have our own)
User documentation @ altinn-studio-docs
Has been added/updated
No functionality has been changed/added, so no documentation is needed
I will do that later/have created an issue
Support in Altinn Studio
Issue(s) created for support in Studio
This change/feature does not require any changes to Altinn Studio
Sprint board
Labels
kind/*andbackport*label to this PR for proper release notes groupingSummary by CodeRabbit