Skip to content

fix(ci): repair Cypress readiness checks on v4.35 - #4388

Merged
olemartinorg merged 1 commit into
release/v4.35from
codex/fix-cypress-node24-readiness-v4.35
Oct 21, 2026
Merged

olemartinorg merged 1 commit into
release/v4.35from
codex/fix-cypress-node24-readiness-v4.35

Conversation

@olemartinorg

Copy link
Copy Markdown
Contributor

Description

Cypress CI can now wait for the frontend server to start on GitHub runner 2.338.0. That runner upgrades the action's Node runtime from 24.19.0 to 24.21.0, exposing a bug in the HTTP client bundled with Cypress action v7.3.0. The readiness check fails immediately with Socket closed before the connection was established, before tests run.

Update all three action references to SHA-pinned v7.4.4, which includes the upstream fix. Apply the same CI fix as #4387 to release/v4.35, where it blocks #4385.

Related Issue(s)

Verification/QA

  • Manual functionality testing

    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests

    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)

    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs

    • Has been added/updated

    • No functionality has been changed/added, so no documentation is needed

    • I will do that later/have created an issue

  • Support in Altinn Studio

    • Issue(s) created for support in Studio

    • This change/feature does not require any changes to Altinn Studio

  • Sprint board

    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels

    • I have added a kind/* and backport* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

Runner 2.338.0 upgrades the action runtime from Node 24.19.0 to
24.21.0. The got@11 client in Cypress action v7.3.0 crashes on an
initial refused connection with Node 24.20.0 and later, before
http-server can start.

Update all three action references to SHA-pinned v7.4.4, which
fixes the readiness check by upgrading got.

Upstream: cypress-io/github-action#1874
@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a799125e-aaf5-4bea-a653-8b7ac4136db8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@olemartinorg olemartinorg added ignore-for-release Pull requests to be ignored in release notes backport-ignore This PR is a new feature and should not be cherry-picked onto release branches approve You approve this PR. Use when: - Small changes - Already agreed upon - Async review labels Oct 21, 2026
@olemartinorg
olemartinorg merged commit 9f848b3 into release/v4.35 Oct 21, 2026
17 of 20 checks passed
@olemartinorg
olemartinorg deleted the codex/fix-cypress-node24-readiness-v4.35 branch October 21, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approve You approve this PR. Use when: - Small changes - Already agreed upon - Async review backport-ignore This PR is a new feature and should not be cherry-picked onto release branches ignore-for-release Pull requests to be ignored in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant