Skip to content

Fix warmup baiting #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
micahwoodard merged 2 commits into from
Oct 1, 2026
Merged

Fix warmup baiting #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
850c58c
fixes warmup baiting
micahwoodard Oct 1, 2026
3f7c96e
adds test
micahwoodard Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...ng/task_logic/trial_generators/coupled_trial_generators/coupled_warmup_trial_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ def next(self):
self.coupled_generator.is_right_choice_history = self.warmup_generator.is_right_choice_history.copy()
self.coupled_generator.reward_history = self.warmup_generator.reward_history.copy()
self.coupled_generator.start_time = self.warmup_generator.start_time
self.coupled_generator.is_left_baited = self.warmup_generator.is_left_baited
self.coupled_generator.is_right_baited = self.warmup_generator.is_right_baited

self._active_generator = self.coupled_generator
trial = self._active_generator.next()
Expand Down
30 changes: 30 additions & 0 deletions tests/trial_generators/test_coupled_warmup_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,36 @@ def test_state_transfer_from_warmup_to_coupled_generator(self):
self.assertEqual(coupled.reward_history, warmup.reward_history)
self.assertEqual(coupled.start_time, warmup.start_time)

def test_baiting_state_transfer_from_warmup_to_coupled_generator(self):
trial = self.generator.next()
outcome = TrialOutcome(
trial=trial,
is_right_choice=np.random.choice([True, False, None]),
is_rewarded=np.random.choice([True, False]),
)

for i in range(50):
trial = self.generator.next()
self.generator.update(outcome)
outcome = simulate_response(
previous_reward=outcome.is_rewarded,
previous_choice=outcome.is_right_choice,
previous_left_bait=False,
previous_right_bait=False,
trial=trial,
)

warmup = self.generator.warmup_generator
warmup.is_left_baited = True
warmup.is_right_baited = False

next_trial = self.generator.next()

self.assertIsNotNone(next_trial)
self.assertIs(self.generator._active_generator, self.generator.coupled_generator)
self.assertEqual(self.generator.coupled_generator.is_left_baited, warmup.is_left_baited)
self.assertEqual(self.generator.coupled_generator.is_right_baited, warmup.is_right_baited)


if __name__ == "__main__":
unittest.main()