Skip to content

AFIT-81: Implementation of configurable parameters in FDD reco #15882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wpierozak wants to merge 7 commits into
base: dev
Choose a base branch
from
+47 −2
Open

AFIT-81: Implementation of configurable parameters in FDD reco #15882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f853b73
Implemented FDD reconstruction parameters and modified reconstruction…
Jul 30, 2026
693e149
Renamed FDD reco param strucutre
Aug 13, 2026
9a6fc58
Updated LinkDef
Aug 14, 2026
1ba2f82
Please consider the following formatting changes
alibuild Aug 14, 2026
b726e54
Merge pull request #10 from alibuild/alibot-cleanup-15681
wpierozak Aug 14, 2026
474e4cd
Added copyright header to FDDRecoConfig.cxx
Aug 14, 2026
dc0203a
Added ClassDefNV statement to FDDRecoConfig struct
Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion DataFormats/Detectors/FIT/FDD/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ o2_add_library(DataFormatsFDD
src/RecPoint.cxx
src/CTF.cxx
src/LookUpTable.cxx
src/FDDRecoConfig.cxx
PUBLIC_LINK_LIBRARIES O2::FDDBase
O2::DataFormatsFIT
O2::SimulationDataFormat
Expand All @@ -29,5 +30,6 @@ o2_target_root_dictionary(DataFormatsFDD
include/DataFormatsFDD/RecPoint.h
include/DataFormatsFDD/RawEventData.h
include/DataFormatsFDD/LookUpTable.h
include/DataFormatsFDD/CTF.h)
include/DataFormatsFDD/CTF.h
include/DataFormatsFDD/FDDRecoConfig.h)

25 changes: 25 additions & 0 deletions DataFormats/Detectors/FIT/FDD/include/DataFormatsFDD/FDDRecoConfig.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
// This software is distributed under the terms of the GNU General Public
// License v3 (GPL Version 3), copied verbatim in the file "COPYING".
//
// In applying this license CERN does not waive the privileges and immunities
// granted to it by virtue of its status as an Intergovernmental Organization
// or submit itself to any jurisdiction.

#ifndef ALICEO2_FDD_DIGIT_FILTER_PARAM
#define ALICEO2_FDD_DIGIT_FILTER_PARAM

@sahilupadhyaya92 sahilupadhyaya92 Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Header guard refers to FDDDigParams.
Maybe change it ?

@wpierozak wpierozak Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes


#include "CommonUtils/ConfigurableParamHelper.h"

namespace o2::fdd
{
struct FDDRecoConfig : o2::conf::ConfigurableParamHelper<FDDRecoConfig> {
double AmplitudeCutOnCollisionTimeWeights = 3;

@sahilupadhyaya92 sahilupadhyaya92 Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"double" is used for "AmplitudeCutOnCollisionTimeWeights".
It is later compared with "adc" which is "Float_t adc = inChData[ich].mChargeADC;"
If no specific reason for the type change, then let's make it float ?

@wpierozak wpierozak Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fine for me

O2ParamDef(FDDRecoConfig, "FDDRecoConfig");
ClassDefNV(FDDRecoConfig, 1);
};
} // namespace o2::fdd
#endif
2 changes: 2 additions & 0 deletions DataFormats/Detectors/FIT/FDD/src/DataFormatsFDDLinkDef.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,6 @@
#pragma link C++ class o2::fdd::CTF + ;
#pragma link C++ class o2::ctf::EncodedBlocks < o2::fdd::CTFHeader, 8, uint32_t> + ;

#pragma link C++ struct o2::fdd::FDDRecoConfig + ;
#pragma link C++ class o2::conf::ConfigurableParamHelper < o2::fdd::FDDRecoConfig> + ;
#endif
15 changes: 15 additions & 0 deletions DataFormats/Detectors/FIT/FDD/src/FDDRecoConfig.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
// This software is distributed under the terms of the GNU General Public
// License v3 (GPL Version 3), copied verbatim in the file "COPYING".
//
// In applying this license CERN does not waive the privileges and immunities
// granted to it by virtue of its status as an Intergovernmental Organization
// or submit itself to any jurisdiction.

#include <DataFormatsFDD/FDDRecoConfig.h>

using namespace o2::fdd;
O2ParamImpl(FDDRecoConfig);
3 changes: 2 additions & 1 deletion Detectors/FIT/FDD/reconstruction/src/Reconstructor.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
#include "FDDBase/Constants.h"
#include <DataFormatsFDD/ChannelData.h>
#include <DataFormatsFDD/Digit.h>
#include <DataFormatsFDD/FDDRecoConfig.h>
#include <fairlogger/Logger.h>

using namespace o2::fdd;
Expand Down Expand Up @@ -53,7 +54,7 @@ void Reconstructor::process(o2::fdd::Digit const& digitBC, gsl::span<const o2::f
continue;
}
Float_t timeErr = 1;
if (adc > 3) {
if (adc > FDDRecoConfig::Instance().AmplitudeCutOnCollisionTimeWeights) {
timeErr = 1. / adc;
}
if ((int)inChData[ich].mPMNumber < 8) {
Expand Down
Loading