Conversation
Please consider the following formatting changes to AliceO2Group#15681
wpierozak
requested review from
afurs,
andreasmolander,
jotwinow and
sahilupadhyaya92
as code owners
October 1, 2026 09:48
| #ifndef O2_MFT_CARECOWORKFLOW_H_ | ||
| #define O2_MFT_CARECOWORKFLOW_H_ | ||
| #ifndef ALICEO2_FDD_DIGIT_FILTER_PARAM | ||
| #define ALICEO2_FDD_DIGIT_FILTER_PARAM |
Collaborator
There was a problem hiding this comment.
Header guard refers to FDDDigParams.
Maybe change it ?
|
|
||
| #endif // O2_MFT_CARECOWORKFLOW_H_ | ||
| struct FDDRecoConfig : o2::conf::ConfigurableParamHelper<FDDRecoConfig> { | ||
| double AmplitudeCutOnCollisionTimeWeights = 3; |
Collaborator
There was a problem hiding this comment.
"double" is used for "AmplitudeCutOnCollisionTimeWeights".
It is later compared with "adc" which is "Float_t adc = inChData[ich].mChargeADC;"
If no specific reason for the type change, then let's make it float ?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved FDD reconstruction parameters from digitizer configuration structure to dedicated configurable structure and updated reconstruction code to use it.
FDDRecoConfig inherits from ConfigurableParamHelper, so it can be modified by either command-line arguments or object fetched from CCDB.