Skip to content

Pass the TAC data file to the performance example #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jwrosewell wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Pass the TAC data file to the performance example #463

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09f73f3
Pass the TAC data file to the performance example
jwrosewell Oct 25, 2026
1031399
Use US spelling of license in the data file comment
jwrosewell Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion ci/run-performance-tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,20 @@ try
$perfSummary = New-Item -ItemType directory -Path test-results/performance-summary -Force
$perfJSONOutputName = "results_$Name.json";

node fiftyone.devicedetection.onpremise/examples/onpremise/performance-console/performance.js --jsonoutput $perfJSONOutputName || $($testsFailed = $true)
# Pass the TAC data file explicitly, so the graph is measured with the full
# data file rather than whichever file the example's folder search finds
# first. Without a license key the TAC file isn't downloaded, and the
# example falls back to its default Lite data file.
$dataFile = 'fiftyone.devicedetection.onpremise/device-detection-cxx/device-detection-data/Enterprise-HashV41.hash'
$dataFileArgs = @()
if (Test-Path $dataFile) {
$dataFileArgs = '--datafile', $dataFile
}
else {
Write-Warning "No TAC data file at '$dataFile', so the example uses its default data file"
}

node fiftyone.devicedetection.onpremise/examples/onpremise/performance-console/performance.js @dataFileArgs --jsonoutput $perfJSONOutputName || $($testsFailed = $true)

Write-Output "Path to performance results - /"

Expand Down
Loading