Repository navigation
Pass the TAC data file to the performance example - #463
Draft
jwrosewell wants to merge 2 commits into
Draft
jwrosewell wants to merge 2 commits into
jwrosewell wants to merge 2 commits into
Conversation
Given no data file, the example searches the folders for 51Degrees-LiteV4.1.hash. In the nightly build that search currently finds the CI's link to the TAC file under tests/ before the Lite file, which depends on the folder order. Pass the TAC file explicitly, and fall back to the example's default when there is no TAC file because no licence key was given.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ci/run-performance-tests.ps1 runs the performance example without a data file. The example then reads
51DEGREES_DD_PATH, and when that isn't set it searches the folders from the repository root for51Degrees-LiteV4.1.hash(exampleUtils.js).In the nightly build, ci/fetch-assets.ps1 creates a link with that name under
fiftyone.devicedetection.onpremise/tests/that points to the TAC file. The search takes the last folder in name order first, so it reachestests/before the real Lite file indevice-detection-cxx/device-detection-data/. The graph is therefore measured with the TAC file at present, but only because of the folder order and a link named after the Lite file.Change
--datafile fiftyone.devicedetection.onpremise/device-detection-cxx/device-detection-data/Enterprise-HashV41.hash, the linkci/fetch-assets.ps1makes to the TAC file.Verification
--datafile <path> --jsonoutput results_Test.json, and without it only--jsonoutput results_Test.json.