Repository navigation
feat(image): The runner image includes file - #52
Merged
Merged
Conversation
Jobs that ran on GitHub-hosted Ubuntu runners rely on `file`, and no package on the runner image's list pulls it in. Install it, check `file --version` in the smoke test, and name it in the README's "What the job gets" list. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38
Summary
A job can now call
fileon the runner without installing it first. Before this, a job that ranfilefailed with a missing command, as it did not on GitHub-hosted Ubuntu runners.The package is installed with
--no-install-recommends, like the rest of the list. The smoke test fails iffile --versiondoes not run, so the gap cannot return unnoticed.Evidence
image/Dockerfileinstalls thefilepackage.file-5.45.image/smoke.shchecksfile --version.check file file --versionprintsok file file-5.45on the rebuilt image. Red against the base image: see below.file.grep -n 'curl,file' README.md` prints line 107 under "What the job gets".file --versionruns in the imagefilepackage):command -v fileprintsfile: absent, so the check has no command to run and would fail. The check itself was not run against the base image.SMOKE PASSEDon the image built from this branch, run withEXPECT_ARCH=aarch64make test: 183 passed, 0 skipped, 0 failed. The existing smoke test passed in the same run, so the existing checks still hold.Not run: linux/amd64 image build and smoke run. The weekly CI build runs them on a native amd64 runner. The Dockerfile change is the same for both architectures.
Merge Danger
Door: two-way. A revert removes
filefrom the install list and the smoke check; no stored data changes.Blast Radius: the runner image's installed tools.
The merge changes the runner image. The weekly build publishes it; no infrastructure or runbook step applies. No feature flag changes.
Reviews
Correctness, Standards, Spec and Security, one round: 2 findings, both pushed back
Correctness, round 1
No findings.
Standards, round 1
Spec, round 1
No findings. The ticket's three criteria are covered above. The linux/amd64 run is listed under Not run.
Security, round 1
No findings. This repo has no security-paths script, so the heading reads "could not be read"; the diff touches no security control.
Tracking
Epic: none
Spec: none
Ticket: #38 Add
fileto the runner imageFlag: none
🤖 Generated with Claude Code