Skip to content

feat(image): The runner image includes file - #52

Merged
sodre merged 1 commit into
mainfrom
t3/add-file-runner-image
Nov 20, 2026
Merged

sodre merged 1 commit into
mainfrom
t3/add-file-runner-image

Conversation

@sodre

@sodre sodre commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Closes #38

Summary

A job can now call file on the runner without installing it first. Before this, a job that ran file failed with a missing command, as it did not on GitHub-hosted Ubuntu runners.

-      gh jq make git curl zstd zip unzip python3 python3-venv python3-pip nodejs \
+      gh jq make git curl file zstd zip unzip python3 python3-venv python3-pip nodejs \

The package is installed with --no-install-recommends, like the rest of the list. The smoke test fails if file --version does not run, so the gap cannot return unnoticed.

Evidence

Criterion Ticked Shown by
image/Dockerfile installs the file package. yes The image built from this branch's Dockerfile runs file-5.45.
image/smoke.sh checks file --version. yes check file file --version prints ok file file-5.45 on the rebuilt image. Red against the base image: see below.
The README's What the job gets list names file. yes grep -n 'curl, file' README.md` prints line 107 under "What the job gets".
Test Red Green
file --version runs in the image On the base image (no file package): command -v file prints file: absent, so the check has no command to run and would fail. The check itself was not run against the base image. SMOKE PASSED on the image built from this branch, run with EXPECT_ARCH=aarch64

make test: 183 passed, 0 skipped, 0 failed. The existing smoke test passed in the same run, so the existing checks still hold.

Not run: linux/amd64 image build and smoke run. The weekly CI build runs them on a native amd64 runner. The Dockerfile change is the same for both architectures.

Merge Danger

Door: two-way. A revert removes file from the install list and the smoke check; no stored data changes.

Blast Radius: the runner image's installed tools.

The merge changes the runner image. The weekly build publishes it; no infrastructure or runbook step applies. No feature flag changes.

Reviews

Correctness, Standards, Spec and Security, one round: 2 findings, both pushed back

Correctness, round 1

No findings.

Standards, round 1

  1. Shotgun Surgery: adding one package edits three files (the Dockerfile list, the smoke check and the README). Pushed back: a shared package list would cover the README only, and it is beyond this ticket.
  2. Duplicated Code: the package list appears in the README prose and the Dockerfile. Pushed back: the README describes the image by design.

Spec, round 1

No findings. The ticket's three criteria are covered above. The linux/amd64 run is listed under Not run.

Security, round 1

No findings. This repo has no security-paths script, so the heading reads "could not be read"; the diff touches no security control.

Tracking

Epic: none
Spec: none
Ticket: #38 Add file to the runner image
Flag: none

🤖 Generated with Claude Code

Jobs that ran on GitHub-hosted Ubuntu runners rely on `file`, and no
package on the runner image's list pulls it in. Install it, check
`file --version` in the smoke test, and name it in the README's
"What the job gets" list.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
@sodre sodre changed the title Image: add file to the runner image feat(image): The runner image includes file Nov 20, 2026
@sodre
sodre merged commit c77035f into main Nov 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add file to the runner image

1 participant