Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #551.
baseXPCallnow usesL.CheckAny(1)instead ofL.CheckFunction(1), allowing callable tables to reach the existing protected-call machinery.pcallalready supports callable tables following #328.Extra arguments remain ignored, preserving Lua 5.1 behavior. A supplied non-callable first argument now returns
falseplus the error handler's result instead of raising an argument-check error, matching Lua 5.1.5's control flow. Diagnostic text may differ.The regression test in
_glua-tests/issues.luacovers callable-table success and error handling.Validation:
make buildgo test -count=1 ./git diff --checkRelated: #467 also removes this check as part of a broader argument-forwarding change. This PR isolates the callable-value fix while keeping the current behavior of not forwarding extra arguments.